From patchwork Fri Nov 20 00:36:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 9750 Received: (qmail 44101 invoked by alias); 20 Nov 2015 00:36:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 44086 invoked by uid 89); 20 Nov 2015 00:36:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Nov 2015 00:36:47 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1ZzZgy-0003bo-MJ from Sandra_Loosemore@mentor.com ; Thu, 19 Nov 2015 16:36:44 -0800 Received: from [IPv6:::1] (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.224.2; Thu, 19 Nov 2015 16:36:44 -0800 To: gdb-patches CC: Pierre-Marie de Rodat From: Sandra Loosemore Subject: [testsuite, committed] Fix think-o in calls to gdb_compile Message-ID: <564E6B0F.7080708@codesourcery.com> Date: Thu, 19 Nov 2015 17:36:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In cross-testing on an arm-none-linux-gnueabi toolchain, I found that the test programs for gdb.base/nested-subp*.exp were being built without the appropriate command-line options for an executable, which was causing them to be un-runnable on the remote target. There's nothing ARM-specific here -- the trouble turned out to be a think-o in the calls to gdb_compile. It wants the literal token "executable" for the argument corresponding to the "type" parameter, not the name of the executable. I think this is a sufficiently obvious fix that I've gone ahead and committed it. -Sandra diff --git a/gdb/testsuite/gdb.base/nested-subp1.exp b/gdb/testsuite/gdb.base/nested-subp1.exp index 9720f5b..adfcad3 100644 --- a/gdb/testsuite/gdb.base/nested-subp1.exp +++ b/gdb/testsuite/gdb.base/nested-subp1.exp @@ -26,7 +26,7 @@ set testcase "nested-subp1" if { [gdb_compile "${srcdir}/${subdir}/${testcase}.c" \ [standard_output_file "${testcase}"] \ - "${testcase}" \ + executable \ [list debug "additional_flags=-std=gnu99"]] != "" } { return -1 } diff --git a/gdb/testsuite/gdb.base/nested-subp2.exp b/gdb/testsuite/gdb.base/nested-subp2.exp index a107d1c..d4fb6f1 100644 --- a/gdb/testsuite/gdb.base/nested-subp2.exp +++ b/gdb/testsuite/gdb.base/nested-subp2.exp @@ -26,7 +26,7 @@ set testcase "nested-subp2" if { [gdb_compile "${srcdir}/${subdir}/${testcase}.c" \ [standard_output_file "${testcase}"] \ - "${testcase}" \ + executable \ [list debug "additional_flags=-std=gnu99"]] != "" } { return -1 } diff --git a/gdb/testsuite/gdb.base/nested-subp3.exp b/gdb/testsuite/gdb.base/nested-subp3.exp index 8f9b522..0cb10f1 100644 --- a/gdb/testsuite/gdb.base/nested-subp3.exp +++ b/gdb/testsuite/gdb.base/nested-subp3.exp @@ -26,7 +26,7 @@ set testcase "nested-subp3" if { [gdb_compile "${srcdir}/${subdir}/${testcase}.c" \ [standard_output_file "${testcase}"] \ - "${testcase}" \ + executable \ [list debug "additional_flags=-std=gnu99"]] != "" } { return -1 }