From patchwork Thu Sep 17 02:35:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 8734 Received: (qmail 99709 invoked by alias); 17 Sep 2015 02:36:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99689 invoked by uid 89); 17 Sep 2015 02:36:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Sep 2015 02:36:38 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZcP3r-0002XM-IP from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Wed, 16 Sep 2015 19:36:35 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Wed, 16 Sep 2015 19:36:35 -0700 Message-ID: <55FA2703.3000205@codesourcery.com> Date: Wed, 16 Sep 2015 20:35:47 -0600 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: gdb-patches Subject: [patch, testsuite] skip gdb.base/gdbinit-history.exp on remote hosts This patch is very similar to the one I posted for gdb.base/gdbhistsize-history.exp yesterday: https://sourceware.org/ml/gdb-patches/2015-09/msg00355.html The rationale is the same -- the test manipulates environment variables in the .exp script. When GDB is run on a remote host it doesn't inherit those environment variables, so the tests cannot possibly work. OK to commit? -Sandra diff --git a/gdb/testsuite/gdb.base/gdbinit-history.exp b/gdb/testsuite/gdb.base/gdbinit-history.exp index 85ef12f..3f726d1 100644 --- a/gdb/testsuite/gdb.base/gdbinit-history.exp +++ b/gdb/testsuite/gdb.base/gdbinit-history.exp @@ -17,6 +17,14 @@ # Test the setting of "history size" via $HOME/.gdbinit +# This test depends on being able to set $HOME and $GDBHISTSIZE. +# We cannot expect remote hosts to see environment variables set on the +# local machine. + +if { [is_remote host] } { + unsupported "can't set environment variables on remote host" + return -1 +} # Check that the history size is properly set to SIZE when reading the .gdbinit # file located in HOME with the environment variable GDBHISTSIZE optionally