diff mbox

[testsuite] skip gdb.base/gdbinit-history.exp on remote hosts

Message ID 55FA2703.3000205@codesourcery.com
State New
Headers show

Commit Message

Sandra Loosemore Sept. 17, 2015, 2:35 a.m. UTC
This patch is very similar to the one I posted for 
gdb.base/gdbhistsize-history.exp yesterday:

https://sourceware.org/ml/gdb-patches/2015-09/msg00355.html

The rationale is the same -- the test manipulates environment variables 
in the .exp script.  When GDB is run on a remote host it doesn't inherit 
those environment variables, so the tests cannot possibly work.

OK to commit?

-Sandra

Comments

Yao Qi Dec. 14, 2015, 9:10 a.m. UTC | #1
Sandra Loosemore <sandra@codesourcery.com> writes:

> This patch is very similar to the one I posted for
> gdb.base/gdbhistsize-history.exp yesterday:
>
> https://sourceware.org/ml/gdb-patches/2015-09/msg00355.html
>
> The rationale is the same -- the test manipulates environment
> variables in the .exp script.  When GDB is run on a remote host it
> doesn't inherit those environment variables, so the tests cannot
> possibly work.

Yes, I can trigger these fails in remote host testing too.

$ make check RUNTESTFLAGS="--host_board=local-remote-host-native --target_board=local-remote-host-native HOST_DIR=/tmp/foo/ gdbinit-history.exp"

FAIL: gdb.base/gdbinit-history.exp: home=gdbinit-history/unlimited: show history size
FAIL: gdb.base/gdbinit-history.exp: home=gdbinit-history/zero: show history size
FAIL: gdb.base/gdbinit-history.exp: home=gdbinit-history/zero: show commands
FAIL: gdb.base/gdbinit-history.exp: home=gdbinit-history/unlimited gdbhistsize=1000: show history size
FAIL: gdb.base/gdbinit-history.exp: home=gdbinit-history/unlimited gdbhistsize=foo: show history size

>
> OK to commit?

Yes, please.
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.base/gdbinit-history.exp b/gdb/testsuite/gdb.base/gdbinit-history.exp
index 85ef12f..3f726d1 100644
--- a/gdb/testsuite/gdb.base/gdbinit-history.exp
+++ b/gdb/testsuite/gdb.base/gdbinit-history.exp
@@ -17,6 +17,14 @@ 
 
 # Test the setting of "history size" via $HOME/.gdbinit
 
+# This test depends on being able to set $HOME and $GDBHISTSIZE.
+# We cannot expect remote hosts to see environment variables set on the
+# local machine.
+
+if { [is_remote host] } {
+    unsupported "can't set environment variables on remote host"
+    return -1
+}
 
 # Check that the history size is properly set to SIZE when reading the .gdbinit
 # file located in HOME with the environment variable GDBHISTSIZE optionally