From patchwork Tue Sep 15 18:35:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 8711 Received: (qmail 99902 invoked by alias); 15 Sep 2015 18:36:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 99887 invoked by uid 89); 15 Sep 2015 18:36:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 18:36:47 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zbv5w-0005ia-DO from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Tue, 15 Sep 2015 11:36:44 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Tue, 15 Sep 2015 11:36:43 -0700 Message-ID: <55F8650E.2020901@codesourcery.com> Date: Tue, 15 Sep 2015 12:35:58 -0600 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: gdb-patches Subject: [patch, testsuite] skip gdb.base/gdbhistsize-history.exp on remote hosts The testcase gdb.base/gdbhistsize-history.exp checks to see whether GDB pays attention to the environment variable GDBHISTSIZE. But, setting the environment variable in the .exp script doesn't work when the host GDB is running on is remote (think of the case where gdb_start runs a ssh command to a remote host to invoke GDB). It seems best just to skip this set of tests in this case. OK to commit? -Sandra diff --git a/gdb/testsuite/gdb.base/gdbhistsize-history.exp b/gdb/testsuite/gdb.base/gdbhistsize-history.exp index 75d98e1..a5d0e43 100644 --- a/gdb/testsuite/gdb.base/gdbhistsize-history.exp +++ b/gdb/testsuite/gdb.base/gdbhistsize-history.exp @@ -18,6 +18,14 @@ # Test the setting of "history size" via the GDBHISTSIZE environment variable +# We cannot expect remote hosts to see environment variables set on the +# local machine. + +if { [is_remote host] } { + unsupported "can't set environment variables on remote host" + return -1 +} + # Check that the history size is properly set to SIZE when the environment # variable ENV_VAR is set to GDBHISTSIZE.