diff mbox

[testsuite] restrict gdb.arch/ppc64-symtab-cordic.exp to ppc64 targets

Message ID 55B957AA.6060506@codesourcery.com
State New
Headers show

Commit Message

Sandra Loosemore July 29, 2015, 10:46 p.m. UTC
I've found that it doesn't do anything useful to try loading a ppc64 .ko 
file when testing GDB on ARM, Nios II, etc.  I copied the target test 
logic from the other gdb.arch/ppc64-*.exp testcase -- is this OK to 
check in?

-Sandra

Comments

Yao Qi July 30, 2015, 11:33 a.m. UTC | #1
On 29/07/15 23:46, Sandra Loosemore wrote:
> 2015-07-29  Sandra Loosemore<sandra@codesourcery.com>
>
> 	gdb/testsuite/
> 	* gdb.arch/ppc64-symtab-cordic.exp: Restrict to ppc64 targets.

Patch is OK to me.
Jan Kratochvil July 30, 2015, 11:59 a.m. UTC | #2
On Thu, 30 Jul 2015 00:46:02 +0200, Sandra Loosemore wrote:
> I've found that it doesn't do anything useful to try loading a ppc64 .ko
> file when testing GDB on ARM, Nios II, etc.  I copied the target test logic
> from the other gdb.arch/ppc64-*.exp testcase -- is this OK to check in?

It should be rather a check for secondary target so that x86* GDB with
--enable-targets=all also runs this test.  But I agree that some arch
restriction should be there so it is up to the maintainers.


Jan
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
index d9a3f13..fa82510 100644
--- a/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
+++ b/gdb/testsuite/gdb.arch/ppc64-symtab-cordic.exp
@@ -13,6 +13,11 @@ 
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+if {![istarget "powerpc*"] || ![is_lp64_target]} {
+    verbose "Skipping powerpc64 separate debug file symtab test."
+    return
+}
+
 standard_testfile
 
 set kobz2file ${srcdir}/${subdir}/cordic.ko.bz2