From patchwork Tue May 26 20:00:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Edjunior Barbosa Machado X-Patchwork-Id: 6928 Received: (qmail 51842 invoked by alias); 26 May 2015 20:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 51831 invoked by uid 89); 26 May 2015 20:00:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e24smtp01.br.ibm.com Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 26 May 2015 20:00:50 +0000 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 May 2015 17:00:45 -0300 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 26 May 2015 17:00:44 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 642EA1DC006A for ; Tue, 26 May 2015 15:59:43 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4QJxTe514483606 for ; Tue, 26 May 2015 16:59:29 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4QK0gtB000910 for ; Tue, 26 May 2015 16:00:42 -0400 Received: from [9.18.235.226] (dawn.br.ibm.com [9.18.235.226] (may be forged)) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t4QK0fpk000901; Tue, 26 May 2015 16:00:42 -0400 Message-ID: <5564D0E9.3000402@linux.vnet.ibm.com> Date: Tue, 26 May 2015 17:00:41 -0300 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support References: <1432041752-4638-1-git-send-email-yao.qi@linaro.org> <1432041752-4638-3-git-send-email-yao.qi@linaro.org> <555E3EAE.2080107@redhat.com> <86h9qzr2g2.fsf@gmail.com> In-Reply-To: <86h9qzr2g2.fsf@gmail.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052620-1524-0000-0000-000002B36A26 X-IsSubscribed: yes On 05/26/2015 08:41 AM, Yao Qi wrote: > Pedro Alves writes: > >> Off by one? >> > Oh, good catch. It should be: > > * linux-record.h (struct linux_record_tdep) : New field. > >> Looked fine to me otherwise (I just skimmed it; didn't really look at >> anything aarch64 specific in detail). > > Thanks for looking at them... I'll push them in. > Hi, noticed this commit (99afc8) introduced this issue when checking for uninitialized vars: gcc -g -O2 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../../gdb/../zlib -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o aarch64-tdep.o -MT aarch64-tdep.o -MMD -MP -MF .deps/aarch64-tdep.Tpo ../../gdb/aarch64-tdep.c ../../gdb/aarch64-tdep.c: In function ‘aarch64_process_record’: ../../gdb/aarch64-tdep.c:2823:23: error: ‘record_buf[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \ ^ ../../gdb/aarch64-tdep.c:3529:12: note: ‘record_buf[0]’ was declared here uint32_t record_buf[2]; ^ The simple patch below intends to fix this. Ok? Thanks, --- Edjunior 2015-05-26 Edjunior Barbosa Machado * aarch64-tdep.c: (aarch64_record_data_proc_simd_fp) Avoid uninitialized variable warning. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index 8597497..73a7f99 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -3526,7 +3526,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r) uint8_t insn_bit21, opcode, rmode, reg_rd; uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15; uint8_t insn_bits11_14; - uint32_t record_buf[2]; + uint32_t record_buf[2] = { 0, 0 }; insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27); insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);