From patchwork Fri May 15 08:32:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: asmwarrior X-Patchwork-Id: 6734 Received: (qmail 20352 invoked by alias); 15 May 2015 08:24:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20343 invoked by uid 89); 15 May 2015 08:24:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 15 May 2015 08:24:43 +0000 Received: by oica37 with SMTP id a37so76981204oic.0 for ; Fri, 15 May 2015 01:24:41 -0700 (PDT) X-Received: by 10.182.245.169 with SMTP id xp9mr1473868obc.82.1431678281308; Fri, 15 May 2015 01:24:41 -0700 (PDT) Received: from [0.0.0.0] (li925-193.members.linode.com. [45.56.75.193]) by mx.google.com with ESMTPSA id xn9sm496505oeb.11.2015.05.15.01.24.38 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 May 2015 01:24:40 -0700 (PDT) Message-ID: <5555AF38.9000100@gmail.com> Date: Fri, 15 May 2015 16:32:56 +0800 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , GDB Patches Subject: Re: [all pushed] Re: [PATCH 00/36] Support building GDB as a C++ program References: <1423524046-20605-1-git-send-email-palves@redhat.com> <54F0B52F.1050909@redhat.com> <54FB20E2.2040403@redhat.com> <54FB3C58.6050702@redhat.com> <550660C5.2060009@gmail.com> <5506661C.1040103@gmail.com> <5506C18C.9080408@redhat.com> <5555AC9F.7020206@gmail.com> In-Reply-To: <5555AC9F.7020206@gmail.com> There is another one build error: In file included from ../../../binutils-gdb/gdb/gdbserver/server.h:61:0, from ../../../binutils-gdb/gdb/gdbserver/server.c:19: ../../../binutils-gdb/gdb/gdbserver/target.h:442:50: error: second operand to the conditional operator is of type 'void', but the third operand is neither a throw-expression nor of type 'void' (*the_target->handle_new_gdb_connection) () : 0) ^ The second operand is a function call which return void, so I have a simply changed the third operand like below: (maybe, we just need a simple if statement instead the conditional operator) Yuanhui Zhang Here is the patch: gdb/gdbserver/target.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h index 8d23383..4affedf 100644 --- a/gdb/gdbserver/target.h +++ b/gdb/gdbserver/target.h @@ -439,7 +439,7 @@ int kill_inferior (int); #define target_handle_new_gdb_connection() \ (the_target->handle_new_gdb_connection ? \ - (*the_target->handle_new_gdb_connection) () : 0) + (*the_target->handle_new_gdb_connection) () : (void)0) #define detach_inferior(pid) \ (*the_target->detach) (pid)