[buildbot] GDB regression on 85880250e591a51624d24db653aaace0c5ce5943
Commit Message
Hi Sergio,
> Nick's commit:
Thanks for reporting this. I have fixed the bug with the patch below.
> On a side note, I can't find Nick's message mentioning the patch on the
> binutils ml.
That's because the message is in PR 17512, where a lot of the recent
patches to minor file formats can be found.
Cheers
Nick
bfd/ChangeLog
2015-01-09 Nick Clifton <nickc@redhat.com>
* tekhex.c (getvalue): Fix thinko in test for correct extraction
of value.
(getsym): Return false if there was not enough data to extract the
symbol.
static struct data_struct *
Comments
On Friday, January 09 2015, Nicholas Clifton wrote:
> Hi Sergio,
>
>> Nick's commit:
>
> Thanks for reporting this. I have fixed the bug with the patch below.
Thanks for fixing this, Nick. Buildbot will build this commit in a
moment and I will let you know if something shows up.
Cheers,
@@ -288,7 +288,7 @@ getvalue (char **srcp, bfd_vma *valuep, char * endp)
*srcp = src;
*valuep = value;
- return len == 0;
+ return len == -1U;
}
static bfd_boolean
@@ -309,7 +309,7 @@ getsym (char *dstp, char **srcp, unsigned int *lenp,
char * endp)
dstp[i] = 0;
*srcp = src + i;
*lenp = len;
- return TRUE;
+ return i == len;
}