From patchwork Fri Oct 10 12:51:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 3186 Received: (qmail 11770 invoked by alias); 10 Oct 2014 12:52:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 11760 invoked by uid 89); 10 Oct 2014 12:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Oct 2014 12:52:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9ACq24X002061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2014 08:52:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9ACq0kx016733; Fri, 10 Oct 2014 08:52:00 -0400 Message-ID: <5437D66F.7060407@redhat.com> Date: Fri, 10 Oct 2014 13:51:59 +0100 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes References: <1411657123-16228-1-git-send-email-palves@redhat.com> <1411657123-16228-4-git-send-email-palves@redhat.com> <87k34au8yc.fsf@codesourcery.com> In-Reply-To: <87k34au8yc.fsf@codesourcery.com> On 10/08/2014 11:55 AM, Yao Qi wrote: > Pedro Alves writes: > > [ThunderBird puts this series into a wrong thread, so I don't see it > until today] > > The patch looks reasonable to me. Thanks. > >> - /* Don't print a message if in the middle of doing a "step n" >> - operation for n > 1 */ >> + /* Notify observers if we finished a "step"-like command, etc. */ >> if (target_has_execution >> && last.kind != TARGET_WAITKIND_SIGNALLED >> && last.kind != TARGET_WAITKIND_EXITED >> - && inferior_thread ()->step_multi >> && inferior_thread ()->control.stop_step) >> - goto done; >> + { >> + /* But not if if in the middle of doing a "step n" operation for > ^^^^^ > Duplicated "if"? Yep. Fixed now. --------- From 31cc0b807b2fde7d0110175418a6eea01a982489 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 10 Oct 2014 13:50:05 +0100 Subject: [PATCH] infrun.c:normal_stop: Fix typo in comment gdb/ 2014-10-10 Pedro Alves * infrun.c (normal_stop): Fix typo in comment. --- gdb/ChangeLog | 4 ++++ gdb/infrun.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aeba430..8d5b1ee 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-10-10 Pedro Alves + + * infrun.c (normal_stop): Fix typo in comment. + 2014-10-09 Sergio Durigan Junior PR tdep/9390 diff --git a/gdb/infrun.c b/gdb/infrun.c index 4681175..5536350 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -6381,7 +6381,7 @@ normal_stop (void) && last.kind != TARGET_WAITKIND_EXITED && inferior_thread ()->control.stop_step) { - /* But not if if in the middle of doing a "step n" operation for + /* But not if in the middle of doing a "step n" operation for n > 1 */ if (inferior_thread ()->step_multi) goto done;