From patchwork Mon Aug 25 09:06:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 2523 Received: (qmail 20128 invoked by alias); 25 Aug 2014 09:02:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20054 invoked by uid 89); 25 Aug 2014 09:02:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pd0-f173.google.com Received: from mail-pd0-f173.google.com (HELO mail-pd0-f173.google.com) (209.85.192.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 25 Aug 2014 09:01:59 +0000 Received: by mail-pd0-f173.google.com with SMTP id w10so19453951pde.18 for ; Mon, 25 Aug 2014 02:01:52 -0700 (PDT) X-Received: by 10.68.179.228 with SMTP id dj4mr9604649pbc.130.1408957311656; Mon, 25 Aug 2014 02:01:51 -0700 (PDT) Received: from [192.168.2.114] ([124.127.118.42]) by mx.google.com with ESMTPSA id bm3sm8675558pbb.82.2014.08.25.02.01.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Aug 2014 02:01:49 -0700 (PDT) Message-ID: <53FAFC9A.5000200@gmail.com> Date: Mon, 25 Aug 2014 17:06:34 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: nickc@redhat.com, amodra@gmail.com CC: binutils@sourceware.org, gdb-patches@sourceware.org Subject: [PATCH] bfd/dwarf2.c: Fix a typo issue related with commit 60d77146a249ae9b51d7ce98930cdbedb2cfa352 According to related commit 60d77146a249ae9b51d7ce98930cdbedb2cfa352, need use 'form' instead of 'name'. The related error (under Darwin x86_64): ../../binutils-gdb/bfd/dwarf2.c:2222:27: error: implicit conversion from enumeration type 'enum dwarf_attribute' to different enumeration type 'enum dwarf_form' [-Werror,-Wenum-conversion] if (is_str_attr (attr.name)) ~~~~~~~~~~~ ~~~~~^~~~ bfd/ChangeLog: * dwarf2.c (find_abstract_instance_name): Use 'form' instead of 'name' for the typo issue, which related with commit 60d77146a249ae9b51d7ce98930cdbedb2cfa352. --- bfd/dwarf2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c index 583504b..1ca69b6 100644 --- a/bfd/dwarf2.c +++ b/bfd/dwarf2.c @@ -2219,7 +2219,7 @@ find_abstract_instance_name (struct comp_unit *unit, case DW_AT_MIPS_linkage_name: /* PR 16949: Corrupt debug info can place non-string forms into these attributes. */ - if (is_str_attr (attr.name)) + if (is_str_attr (attr.form)) name = attr.u.str; break; default: