From patchwork Tue Aug 19 17:20:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 2436 Received: (qmail 8426 invoked by alias); 19 Aug 2014 17:20:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 8409 invoked by uid 89); 19 Aug 2014 17:20:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Aug 2014 17:20:49 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7JHKikq015241 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Aug 2014 13:20:45 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7JHKg6o001857; Tue, 19 Aug 2014 13:20:43 -0400 Message-ID: <53F3876A.6060806@redhat.com> Date: Tue, 19 Aug 2014 18:20:42 +0100 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: [OB/PUSHED] Remove stale comment (was: Re: [PATCH] Set breakpoint on the right line) References: <1407806302-14295-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1407806302-14295-1-git-send-email-yao@codesourcery.com> On 08/12/2014 02:18 AM, Yao Qi wrote: > > /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC > already stays on the line PC while entering "step"/"continue". */ I noticed that this comment is stale. This is no longer true for watchpoints. I've pushed this as obvious. ------------------------- Remove stale comment This comment is no longer true for watchpoints since commit 31e77af2 (PR breakpoints/7143 - Watchpoint does not trigger when first set). gdb/testsuite/ * gdb.base/watchpoint-hw-hit-once.c (main): Update comment. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 060c7a1..d30f7a3 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2014-08-19 Pedro Alves + + * gdb.base/watchpoint-hw-hit-once.c (main): Update comment. + 2014-08-19 Yao Qi * gdb.base/watchpoint-hw-hit-once.exp: Set breakpoint on the diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c index 8ba8ca4..aa64f1d 100644 --- a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c +++ b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.c @@ -22,7 +22,7 @@ main (void) { volatile int dummy; - /* Stub lines are present as no breakpoints/watchpoint gets hit if current PC + /* Stub lines are present as no breakpoint gets hit if current PC already stays on the line PC while entering "step"/"continue". */ dummy = 0; /* Stub to catch WATCHEE access after runto_main. */