diff mbox

Handle powerpc branch instruction on gdb.trace/entry-values.exp

Message ID 53B2B5ED.40607@codesourcery.com
State New
Headers show

Commit Message

Luis Machado July 1, 2014, 1:21 p.m. UTC 
Hi,

This testcase currently does not handle powerpc branches. It kinda does 
in a way, because the arm/aarch64 branch instruction is the same as 
powerpc's, but the target triplet pattern is not there.

In summary, the testcase fails to locate the branch offset and causes a 
failure and the early termination of the test.

The following patch adds a separate conditional block for powerpc (to 
keep things organized), allowing the testcase to continue.

I see full passes and 1 unsupported test now (due to lack of tracepoint 
support).

Luis

Comments

Tom Tromey July 1, 2014, 4:26 p.m. UTC | #1 
>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:

Luis> 2014-07-01  Luis Machado  <lgustavo@codesourcery.com>

Luis> 	* gdb.trace/entry-values.exp: Handle powerpc-specific branch
Luis> 	instruction.

Ok, thanks.

Tom
Luis Machado July 2, 2014, 11:02 a.m. UTC | #2 
On 07/01/2014 05:26 PM, Tom Tromey wrote:
>>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
>
> Luis> 2014-07-01  Luis Machado  <lgustavo@codesourcery.com>
>
> Luis> 	* gdb.trace/entry-values.exp: Handle powerpc-specific branch
> Luis> 	instruction.
>
> Ok, thanks.
>
> Tom
>

Thanks. I've pushed this now.

Luis
diff mbox

Patch

2014-07-01  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.trace/entry-values.exp: Handle powerpc-specific branch
	instruction.

diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index f10ffa6..d648bd1 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -79,6 +79,8 @@  if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } {
     set call_insn "bl"
 } elseif { [istarget "s390*-*-*"] } {
     set call_insn "brasl"
+} elseif { [istarget "powerpc*-*-*"] } {
+    set call_insn "bl"
 } else {
     set call_insn "call"
 }