From patchwork Tue Jun 17 03:44:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 1516 Received: (qmail 22014 invoked by alias); 17 Jun 2014 03:46:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 22001 invoked by uid 89); 17 Jun 2014 03:46:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 03:46:20 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WwkLf-0000zn-PA from Yao_Qi@mentor.com ; Mon, 16 Jun 2014 20:46:15 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 16 Jun 2014 20:46:15 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Mon, 16 Jun 2014 20:46:14 -0700 Message-ID: <539FB99C.4020200@codesourcery.com> Date: Tue, 17 Jun 2014 11:44:28 +0800 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves CC: Tom Tromey , Joel Brobecker , Subject: Re: [ping] [PATCH] Different outputs affected by locale References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> <20140604124708.GR4289@adacore.com> <538F1CC3.9090605@codesourcery.com> <87oay8a0t6.fsf@fleche.redhat.com> <538F803A.9020007@redhat.com> <538FE412.1050806@codesourcery.com> <53903119.6000204@redhat.com> <53903EE5.8090107@codesourcery.com> <539042A2.4050409@redhat.com> <539571C6.40605@codesourcery.com> <53958862.5020106@redhat.com> <5397BCEC.8080300@codesourcery.com> <539990BD.9020504@redhat.com> <5399BB32.5050409@codesourcery.com> <5399E216.1090601@redhat.com> In-Reply-To: <5399E216.1090601@redhat.com> X-IsSubscribed: yes On 06/13/2014 01:23 AM, Pedro Alves wrote: > So what I'm thinking is indeed going with making the test > accept the cent, but conditioned, like: OK, that is more restrict. > > # Fallback to assuming 7-bit ASCII. Test are ran under LC_CTYPE=C. > > set cent "\\\\242" > > set test "show host-charset" > gdb_test_multiple $test $test { > -re "CP1252\r\n$gdb_prompt $" { I tweak the pattern to match the output... > # With Windows code page 1252 (Latin 1), the cent > # is printable. > set cent "\u00A2" > pass $test > } > -re "$gdb_prompt $" { > pass $test > } > } ... and how about the patch below? diff --git a/gdb/testsuite/gdb.base/wchar.exp b/gdb/testsuite/gdb.base/wchar.exp index 4290478..651bd88 100644 --- a/gdb/testsuite/gdb.base/wchar.exp +++ b/gdb/testsuite/gdb.base/wchar.exp @@ -37,6 +37,20 @@ gdb_test "print simple\[2\]" "= 99 L'c'" gdb_test "print difficile\[2\]" "= 65261 L'\\\\xfeed'" set cent "\\\\242" + +set test "show host-charset" +gdb_test_multiple $test $test { + -re "CP1252\".*\r\n$gdb_prompt $" { + # With Windows code page 1252 (Latin 1), the cent + # is printable. + set cent "\u00A2" + pass $test + } + -re "$gdb_prompt $" { + pass $test + } +} + gdb_test "print repeat" "= L\"A\", '$cent' , \"B.*" global hex