Message ID | 537F00EB.5090601@arm.com |
---|---|
State | Committed |
Headers |
Return-Path: <x14314964@homiemail-mx20.g.dreamhost.com> X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id 5E214360079 for <siddhesh@wilcox.dreamhost.com>; Fri, 23 May 2014 01:04:07 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14314964) id E470D41CBD81D; Fri, 23 May 2014 01:04:06 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id C2C5541CBD810 for <gdb@patchwork.siddhesh.in>; Fri, 23 May 2014 01:04:06 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type; q=dns; s=default; b= bPfX/gUBsePsXA/o6pksFX6G+65iG+27Humo0HtqI+JgRmnghG0GCozN151xjpfE J3eSpKiG+1iGTBLJy11rqfT1RnLuNlcCD7/xJrCydaPxnGh3/xI3umHTAt01ofTa 5uLf8j5W6THhwE9/ZJ67gVHQG1m1qtGFEbdzIzTm+gY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type; s=default; bh=6IGM VKQaxxRjOQNxZz/OYh0X1Xw=; b=DOqarbWqxTJwSXVcamZj3mJ2frKB1UjrUcUJ DEINxB9o+MLxxz4XX+dqobbBSkEGKneiAgK49g07gjIUlHbWpB8V03TXGItPnvDJ vX4+5LOpyV2ZSAw0UTUnupr+bYDt4WDvujSEOLltut0MO6JepvquFGjHJnG0N3vu ZtZdEf0= Received: (qmail 28823 invoked by alias); 23 May 2014 08:04:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-gdb=patchwork.siddhesh.in@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 28804 invoked by uid 89); 23 May 2014 08:04:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 May 2014 08:04:03 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 335FE13F64F; Fri, 23 May 2014 03:03:56 -0500 (CDT) Message-ID: <537F00EB.5090601@arm.com> Date: Fri, 23 May 2014 09:03:55 +0100 From: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Joel Brobecker <brobecker@adacore.com> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, Marcus Shawcroft <Marcus.Shawcroft@arm.com> Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c References: <537DBDF3.1080907@arm.com> <20140522124927.GR22822@adacore.com> In-Reply-To: <20140522124927.GR22822@adacore.com> Content-Type: multipart/mixed; boundary="------------070307070406010807010508" X-DH-Original-To: gdb@patchwork.siddhesh.in |
Commit Message
Ramana Radhakrishnan
May 23, 2014, 8:03 a.m. UTC
On 05/22/14 13:49, Joel Brobecker wrote: >> A recent change to glibc removed asm/ptrace.h from user.h for >> AArch64. This meant that cross-native builds of gdb using trunk >> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >> couldn't be found. >> >> Fixed by including asm/ptrace.h like other ports. > > Thanks for the explanation. Can you make sure you include that > in the revision history of your commit? > >> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> >> >> * aarch64-linux-nat.c (asm/ptrace.h): Include. >> > > OK to push. Thank you. > > Thanks - I've got a similar one in gdbserver which I somehow managed to miss yesterday. Ok to push ? regards Ramana commit e9dae05e9c32efda9724330c6d5ade3ca848591d Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> Date: Fri May 23 09:01:14 2014 +0100 Include asm/ptrace.h for linux-aarch64-low.c A recent change to glibc removed asm/ptrace.h from user.h for AArch64. This meant that cross-native builds of gdbserver using trunk glibc broke because linux-aarch64-low.c because user_hwdebug_state couldn't be found. This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e 2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> * linux-aarch64-low.c (asm/ptrace.h): Include.
Comments
On 23/05/14 09:03, Ramana Radhakrishnan wrote: > On 05/22/14 13:49, Joel Brobecker wrote: >>> A recent change to glibc removed asm/ptrace.h from user.h for >>> AArch64. This meant that cross-native builds of gdb using trunk >>> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >>> couldn't be found. >>> >>> Fixed by including asm/ptrace.h like other ports. >> >> Thanks for the explanation. Can you make sure you include that >> in the revision history of your commit? >> >>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> >>> >>> * aarch64-linux-nat.c (asm/ptrace.h): Include. >>> >> >> OK to push. Thank you. >> >> > > Thanks - I've got a similar one in gdbserver which I somehow managed to > miss yesterday. > > Ok to push ? > I'd be inclined to consider this as obvious after yesterday's approval. R. > regards > Ramana > > > > p1.txt > > > commit e9dae05e9c32efda9724330c6d5ade3ca848591d > Author: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > Date: Fri May 23 09:01:14 2014 +0100 > > Include asm/ptrace.h for linux-aarch64-low.c > > A recent change to glibc removed asm/ptrace.h from user.h for AArch64. > This meant that cross-native builds of gdbserver using trunk glibc broke > because linux-aarch64-low.c because user_hwdebug_state couldn't be found. > > This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e > > 2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > > * linux-aarch64-low.c (asm/ptrace.h): Include. > > diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog > index 81bd30e..e591108 100644 > --- a/gdb/gdbserver/ChangeLog > +++ b/gdb/gdbserver/ChangeLog > @@ -1,3 +1,7 @@ > +2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > + > + * linux-aarch64-low.c (asm/ptrace.h): Include. > + > 2014-05-21 Jan Kratochvil <jan.kratochvil@redhat.com> > > Fix TLS access for -static -pthread. > diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c > index 033e79e..6066e15 100644 > --- a/gdb/gdbserver/linux-aarch64-low.c > +++ b/gdb/gdbserver/linux-aarch64-low.c > @@ -26,6 +26,7 @@ > #include <signal.h> > #include <sys/user.h> > #include <sys/ptrace.h> > +#include <asm/ptrace.h> > #include <sys/uio.h> > > #include "gdb_proc_service.h" >
> >>> 2014-05-22 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> > >>> > >>> * aarch64-linux-nat.c (asm/ptrace.h): Include. > >>> > >> > >> OK to push. Thank you. > >> > >> > > > > Thanks - I've got a similar one in gdbserver which I somehow managed to > > miss yesterday. > > > > Ok to push ? Yep! > I'd be inclined to consider this as obvious after yesterday's approval. I agree.
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 81bd30e..e591108 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2014-05-23 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> + + * linux-aarch64-low.c (asm/ptrace.h): Include. + 2014-05-21 Jan Kratochvil <jan.kratochvil@redhat.com> Fix TLS access for -static -pthread. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 033e79e..6066e15 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -26,6 +26,7 @@ #include <signal.h> #include <sys/user.h> #include <sys/ptrace.h> +#include <asm/ptrace.h> #include <sys/uio.h> #include "gdb_proc_service.h"