From patchwork Tue Apr 15 15:47:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Seitz X-Patchwork-Id: 563 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id A0327360072 for ; Tue, 15 Apr 2014 08:48:05 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id 4F5CF62A3494E; Tue, 15 Apr 2014 08:48:05 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id CE3D462A3498C for ; Tue, 15 Apr 2014 08:48:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type; q=dns; s=default; b=qzTMSPJf8wiBeyVxr4hBFXmOormfO 1NzVlV+juJf4T+XL3G4QyTN/DFvxQgUscUxZwm1j0l7vpYcGl4Bgw78ESA4ljjTT SRuW234DuOlVOUqmFFHpQcIKMm0fEEVxtFtBSqDiobXPMNwtOCHhyK7J+vnM6z79 bK0tvJ8x3AkW1U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type; s=default; bh=kYjhgNVT9a7rQs0R/LzQVQAYPFs=; b=SPd kjURskmA35Im87b7ROfpUlCkmlejhnqr3m/yGLLmcUDgKcJTRQRcAaWFP00hm3c3 ZtwGTsWWjCUBB4ku0VtaSggEw/3v0rzgCIRT2pP/z1j42UR7xpZAjYIzNL/fo5MH G9bMIaXIe+Hl8LYrtYX8T/UKXlCLV4aoIHsS8ymE= Received: (qmail 16003 invoked by alias); 15 Apr 2014 15:48:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 15990 invoked by uid 89); 15 Apr 2014 15:48:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL, BAYES_00, LIKELY_SPAM_BODY, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Apr 2014 15:48:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3FFm09d019534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Apr 2014 11:48:00 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3FFlxEN017127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 15 Apr 2014 11:48:00 -0400 Message-ID: <534D54AF.3010501@redhat.com> Date: Tue, 15 Apr 2014 08:47:59 -0700 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA/testsuite] Remove unused globals from mi-break.exp X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in Hi, In a recent email, I asked a contributor to help cleanup some ridiculously long expect regexps. Eating my own dog food, I am going to be submitting some new MI functions which will facilitate regexp construction for breakpoints. This patch simply removes a bunch of unused globals from mi-break.exp. Keith 2014-04-15 Keith Seitz * gdb.mi/mi-break.exp (test_tbreak_creation_and_listing): Remove unused globals. (test_rbreak_creation_and_listing): Likewise. (test_ignore_count): Likewise. (test_error): Likewise. diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp index a9064fd..04dd932 100644 --- a/gdb/testsuite/gdb.mi/mi-break.exp +++ b/gdb/testsuite/gdb.mi/mi-break.exp @@ -56,14 +56,12 @@ set line_callme_body [expr $line_callme_head + 2] set fullname "fullname=\"${fullname_syntax}${srcfile}\"" proc test_tbreak_creation_and_listing {} { - global mi_gdb_prompt global srcfile global hex - global line_callee4_head line_callee4_body - global line_callee3_head line_callee3_body - global line_callee2_head line_callee2_body - global line_callee1_head line_callee1_body - global line_main_head line_main_body + global line_callee4_head + global line_callee3_head + global line_callee2_body + global line_main_body global fullname # Insert some breakpoints and list them @@ -98,14 +96,12 @@ proc test_tbreak_creation_and_listing {} { } proc test_rbreak_creation_and_listing {} { - global mi_gdb_prompt - global srcfile global hex - global line_callee4_head line_callee4_body - global line_callee3_head line_callee3_body - global line_callee2_head line_callee2_body - global line_callee1_head line_callee1_body - global line_main_head line_main_body + global line_callee4_body + global line_callee3_body + global line_callee2_body + global line_callee1_body + global line_main_body # Insert some breakpoints and list them # Also, disable some so they do not interfere with other tests @@ -165,7 +161,6 @@ proc test_abreak_creation {} { } proc test_ignore_count {} { - global mi_gdb_prompt global line_callme_body mi_gdb_test "-break-insert -i 1 callme" \ @@ -179,8 +174,6 @@ proc test_ignore_count {} { } proc test_error {} { - global mi_gdb_prompt - mi_gdb_test "-break-insert function_that_does_not_exist" \ ".*\\^error,msg=\"Function \\\\\"function_that_does_not_exist\\\\\" not defined.\"" \ "breakpoint at nonexistent function" @@ -211,7 +204,6 @@ proc test_error {} { } proc test_disabled_creation {} { - global mi_gdb_prompt global hex global line_callee2_body