From patchwork Tue Apr 15 13:18:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 558 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (peon2454.g.dreamhost.com [208.113.200.127]) by wilcox.dreamhost.com (Postfix) with ESMTP id 130A1360075 for ; Tue, 15 Apr 2014 06:19:08 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id AD898136F770; Tue, 15 Apr 2014 06:19:07 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 76248136F765 for ; Tue, 15 Apr 2014 06:19:07 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; q=dns; s=default; b=UnLlO4yjub3C6e+l84fjZt9TTniSqLUfmEnM8gYa54z KdT1xtjf+aPqm/BebmYFtDMTya7RRW0Nk1On4iG07QbfGagB1tJt7t+gTsJO0UIh C90JLou8bDH0kceJuAelfdsZd1Kl/qWwa0SrVlnxScg7IETE6bjLzjV1bdCeTK9A = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; s=default; bh=aXWcIluYojkjAe66oJP0J9rew6s=; b=Nc857b6k05ypTZJin jdhcHFZ2YjKbbCjFoonPCcW9n9sgRS1FeuGoNAlM7JfrrlElhDETAG9QIrckyXPV eDHYUzxaGNHVPsHc4Se7Z2X+yZsmg1ic8I/leHU8WpLQqRD74GT70vyY9K5KsLml ba7SygSuJOKO40zyJ2xOE4CXoM= Received: (qmail 3795 invoked by alias); 15 Apr 2014 13:19:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3780 invoked by uid 89); 15 Apr 2014 13:19:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Apr 2014 13:19:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3FDIw7Q013107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Apr 2014 09:18:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3FDIuYd013307; Tue, 15 Apr 2014 09:18:57 -0400 Message-ID: <534D31C0.3090403@redhat.com> Date: Tue, 15 Apr 2014 14:18:56 +0100 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pierre Muller , GDB Patches Subject: Re: [pushed] Make sym-file.exp work with remote targets and hosts. References: <1397565489-7311-1-git-send-email-palves@redhat.com> <008401cf58a9$cd7c33a0$68749ae0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <008401cf58a9$cd7c33a0$68749ae0$@muller@ics-cnrs.unistra.fr> X-DH-Original-To: gdb@patchwork.siddhesh.in On 04/15/2014 01:54 PM, Pierre Muller wrote: > Hi Pedro, > > I spotted a small typo error below ... >> >> +#ifdef __linux__ >> +# define SELF_LINK "/proc/self/exe" >> +#elif defined NETBSD >> +# define SELK_LINK "/proc/curproc/exe" >> +#elif defined __OpenBSD__ || defined __FreeBSD__ || defined >> __DragonFly__ >> +# define SELK_LINK "/proc/curproc/file" >> +#elif defined SunOS >> +# define SELK_LINK "/proc/self/path/a.out" >> +#endif > > SELK_LINK => SELF_LINK Thanks Pierre. Fixed, as below. --------------- [PATCH] gdb.base/sym-file-loader.c: Fix typo. SELF_LINK, not SELK_LINK... gdb/testsuite/ 2014-04-15 Pedro Alves * gdb.base/sym-file-loader.c: Fix typo. SELF_LINK, not SELK_LINK. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/sym-file-loader.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 64e4cbd..ca002e9 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2014-04-15 Pedro Alves + * gdb.base/sym-file-loader.c: Fix typo. SELF_LINK, not SELK_LINK. + +2014-04-15 Pedro Alves + * gdb.base/sym-file-loader.c: Include . (SELF_LINK): New define. (get_origin): New function. diff --git a/gdb/testsuite/gdb.base/sym-file-loader.c b/gdb/testsuite/gdb.base/sym-file-loader.c index 625788a..c30ffe1 100644 --- a/gdb/testsuite/gdb.base/sym-file-loader.c +++ b/gdb/testsuite/gdb.base/sym-file-loader.c @@ -81,11 +81,11 @@ load (uint8_t *addr, Elf_External_Phdr *phdr, struct segment *tail_seg) #ifdef __linux__ # define SELF_LINK "/proc/self/exe" #elif defined NETBSD -# define SELK_LINK "/proc/curproc/exe" +# define SELF_LINK "/proc/curproc/exe" #elif defined __OpenBSD__ || defined __FreeBSD__ || defined __DragonFly__ -# define SELK_LINK "/proc/curproc/file" +# define SELF_LINK "/proc/curproc/file" #elif defined SunOS -# define SELK_LINK "/proc/self/path/a.out" +# define SELF_LINK "/proc/self/path/a.out" #endif /* Like RPATH=$ORIGIN, return the dirname of the current