From patchwork Fri Mar 21 08:25:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Zhu X-Patchwork-Id: 202 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (caibbdcaabja.dreamhost.com [208.113.200.190]) by wilcox.dreamhost.com (Postfix) with ESMTP id 49448360078 for ; Fri, 21 Mar 2014 01:26:05 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id EBD1F61CF5502; Fri, 21 Mar 2014 01:26:04 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id BBF0461CE8D2B for ; Fri, 21 Mar 2014 01:26:04 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=CiZZAyns7moLjUPv wBxFmCXAaA0xnO6kWHg7rDZc61apVqvsS2xJQ0+yP2qQuu8ATlExBn9Pnfb8wfAV VDyU+5OiErQeakCZN6cYJqHjGmC8CRmwHGKUVVuD+Q246AOxVrCvpWaGtp5iJfwP l/dOVi73hUfz62EKw8hLJvh67ZI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=JGSDrZ+IYzA9x6aYbvuspL kVNvY=; b=eNR4/IKbyIZ9vwsygq37zA0If19eiVlvU3LcfVeZ8MTxdyAjrAn76U 3mjd704FZoFoadCLVvE2T8mpDyhZ5ChO3phV3E7XFE/F23wypMGn1N8TFJT0Pp1D oVd5nYuXO6CIXeNkfsWBullI5WDcm18Ee+6b/rwsaPbwYvZ/0VYZE= Received: (qmail 26832 invoked by alias); 21 Mar 2014 08:26:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26819 invoked by uid 89); 21 Mar 2014 08:26:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Mar 2014 08:26:00 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WQum3-0006kG-Lm from Hui_Zhu@mentor.com ; Fri, 21 Mar 2014 01:25:55 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 21 Mar 2014 01:25:55 -0700 Received: from localhost.localdomain (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Fri, 21 Mar 2014 01:25:54 -0700 Message-ID: <532BF790.90401@mentor.com> Date: Fri, 21 Mar 2014 16:25:52 +0800 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Eli Zaretskii , , Pedro Alves CC: Subject: Re: [PATCH/doc] Remove fixme of packet "k" References: <5322AE41.4050008@mentor.com> <5328B210.9060702@earthlink.net> <53294F15.4050503@mentor.com> <83d2hi9ngv.fsf@gnu.org> <532A6417.1010106@mentor.com> <83ha6s97o7.fsf@gnu.org> In-Reply-To: <83ha6s97o7.fsf@gnu.org> X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in On 03/21/14 00:06, Eli Zaretskii wrote: >> Date: Thu, 20 Mar 2014 11:44:23 +0800 >> From: Hui Zhu >> CC: , >> >> Updated a new version according to your comments. > > This version is OK, thanks. > Make a new patch according to your comments. Please help me review it. Thanks, Hui 2014-03-21 Pedro Alves Stan Shebs Hui Zhu * gdb.texinfo (Packets): Add anchor to "? packet". Remove fixme and update introduction of "k packet". Add anchor to "vKill packet". --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -33742,6 +33742,7 @@ The remote target both supports and has @item ? @cindex @samp{?} packet +@anchor{? packet} Indicate the reason the target halted. The reply is the same as for step and continue. This packet has a special interpretation when the target is in non-stop mode; see @ref{Remote Non-Stop}. @@ -33954,9 +33955,25 @@ step packet}. @cindex @samp{k} packet Kill request. -FIXME: @emph{There is no description of how to operate when a specific -thread context has been selected (i.e.@: does 'k' kill only that -thread?)}. +The exact effect of this packet is not specified. + +For a bare-metal target, it may power cycle or reset the target +system. For that reason, the @samp{k} packet has no reply. + +For a single-process target, it may kill that process if possible. + +A multiple-process target may choose to kill just one process, or all +that are under @value{GDBN}'s control. For more precise control, use +the vKill packet (@pxref{vKill packet}). + +If the target system immediately closes the connection in response to +@samp{k}, @value{GDBN} does not consider the lack of packet +acknowledgment to be an error, and assumes the kill was successful. + +If connected using @kbd{target extended-remote}, and the target does +not close the connection in response to a kill request, @value{GDBN} +probes the target state as if a new connection was opened +(@pxref{? packet}). @item m @var{addr},@var{length} @cindex @samp{m} packet @@ -34258,6 +34275,7 @@ request is completed. @item vKill;@var{pid} @cindex @samp{vKill} packet +@anchor{vKill packet} Kill the process with the specified process ID. @var{pid} is a hexadecimal integer identifying the process. This packet is used in preference to @samp{k} when multiprocess protocol extensions are