From patchwork Thu Mar 20 03:44:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Zhu X-Patchwork-Id: 187 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (caibbdcaabja.dreamhost.com [208.113.200.190]) by wilcox.dreamhost.com (Postfix) with ESMTP id 1B6DA3600E9 for ; Wed, 19 Mar 2014 20:44:45 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14314964) id A2CE4627BD361; Wed, 19 Mar 2014 20:44:44 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 858026272AB01 for ; Wed, 19 Mar 2014 20:44:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=X8/5eL6k+VtY6zPA udWfF4dxyJ1RYBTesopcG2FSlVcYyRnj/whTgKtCfowy80GGAmeEG8uTGFQQ2Dm9 Q6/p05XEgfdlYXCg5+/dlw6j74YUtyezYx+SgGdxFLplZIiadkjxANoIwt9X9p8r awTJdIlFENwInqHkMPTPAk2ZuTQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=6U2RcijIzwHZULnzonQewo iCXmg=; b=VPNnFizcScepQTFuVBxSUEMUvdv01daMx0R12rxP7BUNmRjPwqDnUY Ahs6Q9U4i8CsGYhxiqe2neE4fvqx3RxjpigKdhfskRDcNKewvKN5aNd3qxpaQ7iH 3HPgLG8TJ9n/xVF6Nm5ycJgloBMLQPUMAwds9pT8MU6RCyNOP2+/M= Received: (qmail 4218 invoked by alias); 20 Mar 2014 03:44:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 4207 invoked by uid 89); 20 Mar 2014 03:44:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Mar 2014 03:44:41 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WQTuF-0000Bu-KD from Hui_Zhu@mentor.com ; Wed, 19 Mar 2014 20:44:35 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 19 Mar 2014 20:44:35 -0700 Received: from localhost.localdomain (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Wed, 19 Mar 2014 20:42:36 -0700 Message-ID: <532A6417.1010106@mentor.com> Date: Thu, 20 Mar 2014 11:44:23 +0800 From: Hui Zhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: , Subject: Re: [PATCH/doc] Remove fixme of packet "k" References: <5322AE41.4050008@mentor.com> <5328B210.9060702@earthlink.net> <53294F15.4050503@mentor.com> <83d2hi9ngv.fsf@gnu.org> In-Reply-To: <83d2hi9ngv.fsf@gnu.org> X-IsSubscribed: yes X-DH-Original-To: gdb@patchwork.siddhesh.in On 03/20/14 00:12, Eli Zaretskii wrote: >> Date: Wed, 19 Mar 2014 16:02:29 +0800 >> From: Hui Zhu >> CC: Eli Zaretskii >> >> Hi Stan, >> >> According to your comments. I make a new patch. >> >> Thanks, >> Hui >> >> 2014-03-19 Stan Shebs >> Hui Zhu >> >> * gdb.texinfo (k packet): Remove fixme and update introduction. >> (vKill packet): Add anchor. > > Thanks. But these changes are both in the node called "Packets", not > "k packet" or "vKill packet", so please change the text in parentheses > to name the node (just once). > >> +A multiple-process target may choose to kill just one process, or all >> +that that are under GDB's control. For more precise control, use the > ^^^^^^^^^ > One "that" is redundant. > >> +vKill packet.(@pxref{vKill packet}) > > @pxref should be before the period, like this: > > vKill packet (@pxref{vKill packet}). > > OK with those changes. > Updated a new version according to your comments. Please help me review it. Thanks, Hui 2014-03-20 Stan Shebs Hui Zhu * gdb.texinfo (Packets): Remove fixme and update introduction of "k packet". Add anchor to "vKill packet". --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -33952,11 +33952,16 @@ step packet}. @item k @cindex @samp{k} packet -Kill request. +Kill the target process or processes. -FIXME: @emph{There is no description of how to operate when a specific -thread context has been selected (i.e.@: does 'k' kill only that -thread?)}. +The exact effect of this packet is not specified. For a single-process +target, it will kill that process if possible. + +A multiple-process target may choose to kill just one process, or all +that are under GDB's control. For more precise control, use the +vKill packet (@pxref{vKill packet}). + +The @samp{k} packet has no reply. @item m @var{addr},@var{length} @cindex @samp{m} packet @@ -34258,6 +34263,7 @@ request is completed. @item vKill;@var{pid} @cindex @samp{vKill} packet +@anchor{vKill packet} Kill the process with the specified process ID. @var{pid} is a hexadecimal integer identifying the process. This packet is used in preference to @samp{k} when multiprocess protocol extensions are