From patchwork Mon Mar 17 17:02:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 127 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id 29303360110 for ; Mon, 17 Mar 2014 10:02:13 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id CDB3EC7886C; Mon, 17 Mar 2014 10:02:12 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 9BFDF2780949 for ; Mon, 17 Mar 2014 10:02:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; q=dns; s=default; b=AUAOTCDjVoiZmzafETzawgdbt5sUsyu0/R1i7+ioRwZ vWP0mG/Ftn/rUs/epazUSBIxAky4SZOD53MPvxGz8vFAzkAyjkJUwS3TicBVRQl5 HDJriYLRicoAHDaFX7ysVR93WSCYYQnjI7504wXLFyOPjE015jlf0BDSy2al9H3g = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; s=default; bh=CJlCWyBBr+ZVNLiyMHlPr78q1ek=; b=s03kZBIel4BvMjjV8 +TJub0k8gnsRTVAgqS1eWtKSGsRJbnKRrv2XaI0D4gdpmwXUOgP5o7aEnemkd8B5 UkBZek1ReIQqwG6D/6OyXKkIrS+ykFib3jq5ALg/jCdAodM2y6SagNAP4GcglWl7 tZRkVnOVnpv7OjrwYD7xBu26Gs= Received: (qmail 31311 invoked by alias); 17 Mar 2014 17:02:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31295 invoked by uid 89); 17 Mar 2014 17:02:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, MISSING_HEADERS, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Mar 2014 17:02:09 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2HH26VO001784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 17 Mar 2014 13:02:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2HH25sm024212 for ; Mon, 17 Mar 2014 13:02:05 -0400 Message-ID: <53272A8C.8080706@redhat.com> Date: Mon, 17 Mar 2014 17:02:04 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 CC: gdb-patches@sourceware.org Subject: [PATCH 0.5/8] Rename "target child" to "target native". References: <1395069784-7406-1-git-send-email-palves@redhat.com> In-Reply-To: <1395069784-7406-1-git-send-email-palves@redhat.com> X-DH-Original-To: gdb@patchwork.siddhesh.in Whoop, pilot error... On 03/17/2014 03:22 PM, Pedro Alves wrote: > Pedro Alves (8): > Rename "target djgpp" -> "target native" > Rename "target darwin-child" -> "target native" > Rename "target GNU" -> "target native" > Windows: Rename "target child" -> "target native" > nto-procfs.c: Add "target native". > go32-nat.c: Don't override to_open. > NEWS: Mention native target renames. > Allow making GDB not automatically connect to the native target. I missed including in the series the real patch #1, the one that renames "target child" -> "target native". Here is is. --- [PATCH 1/9] Rename "target child" to "target native". I had been pondering renaming "target child" to something else. "child" is a little lie in case of "attach", and not exactly very clear to users, IMO. By best suggestion is "target native". If I were to explain what "target child" is, I'd just start out with "it's the native target" anyway. I was worrying a little that "native" might be a lie too if some port comes up with a default target that can run but is not really native, but I think that's a very minor issue - we can consider that "native" really means the default built in target that GDB supports, instead of saying that's the target that debugs host native processes, if it turns out necessary. This change doesn't affect users much, because "target child" results in error today: (gdb) target child Use the "run" command to start a child process. Other places "child" is visible: (gdb) help target ... List of target subcommands: target child -- Child process (started by the "run" command) target core -- Use a core file as a target target exec -- Use an executable file as a target ... (gdb) info target Symbols from "/home/pedro/gdb/mygit/build/gdb/gdb". Child process: Using the running image of child Thread 0x7ffff7fc9740 (LWP 4818). While running this, GDB does not access memory from... ... These places will say "native" instead. I think that's a good thing. gdb/ 2014-03-17 Pedro Alves * inf-child.c (inf_child_open): Remove mention of "child". (inf_child_target): Rename target to "native" instead of "child". gdb/testsuite/ 2014-03-17 Pedro Alves * gdb.base/default.exp: Test "target native" instead of "target child". --- gdb/inf-child.c | 8 ++++---- gdb/testsuite/gdb.base/default.exp | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/inf-child.c b/gdb/inf-child.c index 282467b..8a99adc 100644 --- a/gdb/inf-child.c +++ b/gdb/inf-child.c @@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self, static void inf_child_open (char *arg, int from_tty) { - error (_("Use the \"run\" command to start a child process.")); + error (_("Use the \"run\" command to start a process.")); } static void @@ -406,9 +406,9 @@ inf_child_target (void) { struct target_ops *t = XCNEW (struct target_ops); - t->to_shortname = "child"; - t->to_longname = "Child process"; - t->to_doc = "Child process (started by the \"run\" command)."; + t->to_shortname = "native"; + t->to_longname = "Native process"; + t->to_doc = "Native process (started by the \"run\" command)."; t->to_open = inf_child_open; t->to_post_attach = inf_child_post_attach; t->to_fetch_registers = inf_child_fetch_inferior_registers; diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index a39ffcf..3636fa3 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -746,8 +746,8 @@ gdb_test "step" "The program is not being run." "step #2" #test symbol-file gdb_test "symbol-file" ".*" "symbol-file" -#test target child -gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" +#test target native +gdb_test "target native" "Use the \"run\" command to start a process.*|Undefined target command: \"child\". *Try \"help target\".*" "target native" #test target core send_gdb "target core\n"