From patchwork Thu Mar 13 12:30:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 69 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx21.g.dreamhost.com (caibbdcaaahb.dreamhost.com [208.113.200.71]) by wilcox.dreamhost.com (Postfix) with ESMTP id 12F0D3600D9 for ; Thu, 13 Mar 2014 05:30:40 -0700 (PDT) Received: by homiemail-mx21.g.dreamhost.com (Postfix, from userid 14314964) id 9BB171350C83; Thu, 13 Mar 2014 05:30:39 -0700 (PDT) X-Original-To: gdb@patchwork.siddhesh.in Delivered-To: x14314964@homiemail-mx21.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx21.g.dreamhost.com (Postfix) with ESMTPS id 5FD181350C9A for ; Thu, 13 Mar 2014 05:30:39 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=a2jwYpCb1Zlksujh ui1dbgOeFpTH45JTmRUJsYYz3L3uAuTjzEvq36lGfqtcOctIH3OrLt9GVLRSfzjZ hafBtbM6mGsd2CMJBSAYmF2G/ZjwUxUDtG+hYUXKGvOpV+miwLM7nqSlr8qj31f4 bz8KfhUEB1deyk+p1xegoSTmXh4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; s=default; bh=z1y5QLpT64WuQwDxPTFpjl kQAH8=; b=ERYRdp3lsUCKNWd4spFn1kQD0gHwrlRw5G0qFOPJxcFwJWPqiyGyOi t1bgMvs/m5SN4JD1eUpZeEa5PZpgLPUy3IIshBt5Jc9h08Va4x54aT9tD+gvVfKN wpKQfDqDpIbjyqab7LGPRqeL/XqPn4Q9197oFePV3ePXEj+gmofr0= Received: (qmail 2335 invoked by alias); 13 Mar 2014 12:30:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2318 invoked by uid 89); 13 Mar 2014 12:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Mar 2014 12:30:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2DCUPBX027155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Mar 2014 08:30:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2DCU1sF018010; Thu, 13 Mar 2014 08:30:01 -0400 Message-ID: <5321A4C8.80909@redhat.com> Date: Thu, 13 Mar 2014 12:30:00 +0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: gdb-patches CC: Doug Evans , Gary Benson Subject: Re: [PATCH] Don't mention "Unix" in native target name. References: <1394627872-18619-1-git-send-email-palves@redhat.com> <20140312131607.GA5531@blade.nx> In-Reply-To: X-DH-Original-To: gdb@patchwork.siddhesh.in On 03/13/2014 12:13 AM, Doug Evans wrote: > On Wed, Mar 12, 2014 at 6:16 AM, Gary Benson wrote: >> Pedro Alves wrote: >>> How about we just say the same mostly everywhere? >> >> I'm all for this. >> >>> In the same vein, I'd also rename Solaris/procfs.c's "target procfs" >>> to "target child". >> >> Ditto. > > +1 Thanks guys. Judging from the quick positive reactions, seems like everyone's in favor, so I've pushed this in. --------- [PATCH] Don't mention "Unix" in native target name. I find the mention of "Unix" unnecessary (and really slightly a lie) on GNU/Linux in a couple of places: (gdb) maint print target-stack The current target stack is: - multi-thread (multi-threaded child process.) - child (Unix child process) - exec (Local exec file) - None (None) (gdb) help target child Unix child process (started by the "run" command). (gdb) target child Use the "run" command to start a Unix child process. It's also odd that e.g., the Windows port says "Unix" in reaction to "target child" (it was already that way before Windows used inf-child.c): (gdb) target child Use the "run" command to start a Unix child process. (gdb) So drop "Unix", going in the direction of saying mostly the same on all native targets: (gdb) maint print target-stack The current target stack is: - multi-thread (multi-threaded child process.) - - child (Unix child process) + - child (Child process) - exec (Local exec file) - None (None) (gdb) help target child - Unix child process (started by the "run" command). + Child process (started by the "run" command). (gdb) target child -Use the "run" command to start a Unix child process. +Use the "run" command to start a child process. gdb/ 2014-03-13 Pedro Alves * inf-child.c (inf_child_open, inf_child_target): Don't mention Unix in user visible strings. gdb/testsuite/ 2014-03-13 Pedro Alves * gdb.base/default.exp: Update "target child" and "target procfs" tests to not expect "Unix". --- gdb/ChangeLog | 5 +++++ gdb/inf-child.c | 6 +++--- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/default.exp | 4 ++-- 4 files changed, 15 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b1f4b50..8ce0f98 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-03-13 Pedro Alves + + * inf-child.c (inf_child_open, inf_child_target): Don't mention + Unix in user visible strings. + 2014-03-12 Stan Shebs * gdbtypes.h: Annotate comments for Doxygen, add a page diff --git a/gdb/inf-child.c b/gdb/inf-child.c index c6483f9..cc16b40 100644 --- a/gdb/inf-child.c +++ b/gdb/inf-child.c @@ -112,7 +112,7 @@ inf_child_prepare_to_store (struct target_ops *self, static void inf_child_open (char *arg, int from_tty) { - error (_("Use the \"run\" command to start a Unix child process.")); + error (_("Use the \"run\" command to start a child process.")); } static void @@ -407,8 +407,8 @@ inf_child_target (void) struct target_ops *t = XCNEW (struct target_ops); t->to_shortname = "child"; - t->to_longname = "Unix child process"; - t->to_doc = "Unix child process (started by the \"run\" command)."; + t->to_longname = "Child process"; + t->to_doc = "Child process (started by the \"run\" command)."; t->to_open = inf_child_open; t->to_post_attach = inf_child_post_attach; t->to_fetch_registers = inf_child_fetch_inferior_registers; diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5180a25..7e7cb67 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-03-13 Pedro Alves + + * gdb.base/default.exp: Update "target child" and "target procfs" + tests to not expect "Unix". + 2014-03-12 Tom Tromey * gdb.base/corefile.exp (corefile_test_run, corefile_test_attach): diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index 73c33ba..b63955e 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -747,10 +747,10 @@ gdb_test "step" "The program is not being run." "step #2" gdb_test "symbol-file" ".*" "symbol-file" #test target child -gdb_test "target child" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" +gdb_test "target child" "Use the \"run\" command to start a child process.*|Undefined target command: \"child\". *Try \"help target\".*" "target child" #test target procfs -gdb_test "target procfs" "Use the \"run\" command to start a Unix child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" +gdb_test "target procfs" "Use the \"run\" command to start a child process.*|Undefined target command: \"procfs\". *Try \"help target\".*" "target procfs" #test target core send_gdb "target core\n"