From patchwork Sat Apr 6 17:03:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88134 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 519443858C31 for ; Sat, 6 Apr 2024 17:04:43 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6745A3858429 for ; Sat, 6 Apr 2024 17:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6745A3858429 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6745A3858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; cv=none; b=ta1YhNBiJQYTILSLMZ3zQOe6HdKyQXgVgsdcn99nuU1PQKHR/Ma22nsG3iuHFdXT+CXbcYcze86k18l6IroZYh7PHFYjvS9BTPnI1835DD0PrVX65KmDj37I/Y0elZO9o1imjXkh1xYMNsmOsq4kv8LogwG4XTaX4T49nkn/wAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712423016; c=relaxed/simple; bh=PQ/Td58yCIakTT3310yzj3gkDB2juJfe7zJK/5UYKYE=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=SkjTya4RkkiqGm0fvebX009BmYJrrfQQq3a9uFlPI7107xAu2WOdnGGZWvaBD1kjpOSdN/nYQ/br3b2vb5EBIaR1MFBNAHD2ymI7mK8Wr1cyjBiouTxBZ1TONbCvMwhg/+Px0d85O6zdRTLMedbKERlnwvqVdeJ2FSHYsllvu2M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712423014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vsNU60J+SXoY4aAMjiZ453MiUlxSfyaK6KqWFpqmdKg=; b=EqmTY0+sLMMTskKtPOfoNXotcMDJqhVLxdnlFEqSPRxnL/Na+uyutyT/KFH6NWDMqQYM2i j1hJ7sRQlxvhtk2UZMqRFoCbVSlcywh1VCxkQC1otBy0SfXfgo2/uL8EfsQLV1+Vb8kDkQ lZqaG9hS+xB75mQ+fXRFHG463yTWtKA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-Dwmj4tMhP6SUk6GLs3rlxw-1; Sat, 06 Apr 2024 13:03:29 -0400 X-MC-Unique: Dwmj4tMhP6SUk6GLs3rlxw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-56e2a11ff78so1105106a12.0 for ; Sat, 06 Apr 2024 10:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712423008; x=1713027808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vsNU60J+SXoY4aAMjiZ453MiUlxSfyaK6KqWFpqmdKg=; b=vsqu26yAeDc1xDEsDXRT9pqbqlPOGkq7/wfE1BMEpqWs8cD+ODt/Van+dfyw9EZC7B W2LGZ7oZ7+P+IX4eH5FoSOn7enx/gNNTTliJgWHe9RlFrYco5MZDh4mK7CmJ9faIYMPn rOyTImD4DM2JTiN4Kzl5DpRtrmxnyjxY0jSg8WnhS0ol+nCYlJT7oF0dDCMKuCIZ1gQU Txs7w8kG9F3nXGoPjAJ27afPGAVDcgwriC9K9XR39MBFb+SPGARvddJeqNvtNQYQG3KO vgOSxOcWRYpozbIz/52RlV/GrT68Y6QYtPh0AKkSzyMkGCg6c/5vB1ARngSExpK9abAL iqlQ== X-Gm-Message-State: AOJu0YyxOzdyedzC2WcJBVTaPyXdV2UtXIxDZEq8BGts2Q55uisezPPZ 2h+rSwGrrzpe810hX8HVwDyFxpNmeAEla+ynJ9pDozMw2+WvMkx4kx7neoTQJ+wSX2fYwJ1lg9W x99oeCjNyWSukb448uVdLaxETOUVYij5+P9H84sVveLT9AW4cuI4lfLmfyhZhUbR5KAVPc532cf c3aTJIiz5RwdqcJjFmqtxchDGJdTWfrlrD8Fsb1Bm6Jdg= X-Received: by 2002:a50:d61c:0:b0:56e:33fe:5e88 with SMTP id x28-20020a50d61c000000b0056e33fe5e88mr2955886edi.34.1712423008060; Sat, 06 Apr 2024 10:03:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnJbAUQ5iuzj+Fgw3ODFwuIWfWRZu5zqNC5UNObLaripTGZKDQvZq20IPF7vzCyslo+1sl5g== X-Received: by 2002:a50:d61c:0:b0:56e:33fe:5e88 with SMTP id x28-20020a50d61c000000b0056e33fe5e88mr2955877edi.34.1712423007721; Sat, 06 Apr 2024 10:03:27 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id es18-20020a056402381200b0056a033fa007sm2046961edb.64.2024.04.06.10.03.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 10:03:27 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 5/6] gdb/configure: use AC_MSG_NOTICE not a direct echo call Date: Sat, 6 Apr 2024 18:03:14 +0100 Message-Id: <51e77408f8d95ebdca75e56237b213c0368e996d.1712422921.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org After the recent commits, I noticed that GDB's configure script would still emit two lines even when run in silent mode. If you touch gdb/Makefile.in and then run 'make all' in the gdb/ build directory you'll see this: GEN config.status enable_sim = no enableval = no Obviously the 'no' might be 'yes' depending on how you actually configured GDB. This is caused by two direct invocations of 'echo' in GDB's configure.ac script. In this commit I replace these calls with use of AC_MSG_NOTICE instead. Now when configure is run with the --silent command line option these lines will not be printed. There should be no changes in the built GDB after this commit. --- gdb/configure | 6 ++++-- gdb/configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/configure b/gdb/configure index d0fd1760b88..ffbc14493e2 100755 --- a/gdb/configure +++ b/gdb/configure @@ -32848,8 +32848,10 @@ fi # # Check whether --enable-sim was given. if test "${enable_sim+set}" = set; then : - enableval=$enable_sim; echo "enable_sim = $enable_sim"; - echo "enableval = ${enableval}"; + enableval=$enable_sim; { $as_echo "$as_me:${as_lineno-$LINENO}: enable_sim = $enable_sim" >&5 +$as_echo "$as_me: enable_sim = $enable_sim" >&6;}; + { $as_echo "$as_me:${as_lineno-$LINENO}: enableval = ${enableval}" >&5 +$as_echo "$as_me: enableval = ${enableval}" >&6;}; case "${enableval}" in yes) ignore_sim=false ;; no) ignore_sim=true ;; diff --git a/gdb/configure.ac b/gdb/configure.ac index aa91bfb3a17..28e750b6b43 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -2032,8 +2032,8 @@ AC_PATH_X # AC_ARG_ENABLE(sim, AS_HELP_STRING([--enable-sim], [link gdb with simulator]), -[echo "enable_sim = $enable_sim"; - echo "enableval = ${enableval}"; +[AC_MSG_NOTICE([enable_sim = $enable_sim]); + AC_MSG_NOTICE([enableval = ${enableval}]); case "${enableval}" in yes) ignore_sim=false ;; no) ignore_sim=true ;;