From patchwork Sun Sep 22 02:15:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 34634 Received: (qmail 129974 invoked by alias); 22 Sep 2019 02:16:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 127870 invoked by uid 89); 22 Sep 2019 02:15:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=administrator, Administrator X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Sep 2019 02:15:10 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 556E51E593; Sat, 21 Sep 2019 22:15:07 -0400 (EDT) Subject: Re: New ARI warning Sun Sep 22 01:58:01 UTC 2019 To: GDB Administrator , gdb-patches@sourceware.org References: <20190922015801.GA30147@sourceware.org> From: Simon Marchi Message-ID: <4e3f56b0-2a7d-f116-6837-2066a0c90e3f@simark.ca> Date: Sat, 21 Sep 2019 22:15:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190922015801.GA30147@sourceware.org> On 2019-09-21 9:58 p.m., GDB Administrator wrote: > 492a493 >> gdb/solib-svr4.c:3232: code: OP eol: Do not use &&, or || at the end of a line > gdb/solib-svr4.c:3232: if (abfd != nullptr && I pushed this patch to fix it. From 7ab78ccbbb0d0918c293ade07bea59d789ea7d63 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sat, 21 Sep 2019 22:13:49 -0400 Subject: [PATCH] gdb: fix formatting in solib-svr4.c gdb/ChangeLog: * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix formatting. --- gdb/ChangeLog | 5 +++++ gdb/solib-svr4.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 48f90186ffab..4374348c8df7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-09-21 Simon Marchi + + * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix + formatting. + 2019-09-21 Simon Marchi * breakpoint.h (bp_location) : diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c index dc635491058a..aa4af346b453 100644 --- a/gdb/solib-svr4.c +++ b/gdb/solib-svr4.c @@ -3229,8 +3229,8 @@ svr4_iterate_over_objfiles_in_search_order else abfd = current_objfile->obfd; - if (abfd != nullptr && - scan_dyntag (DT_SYMBOLIC, abfd, nullptr, nullptr) == 1) + if (abfd != nullptr + && scan_dyntag (DT_SYMBOLIC, abfd, nullptr, nullptr) == 1) { checked_current_objfile = true; if (cb (current_objfile, cb_data) != 0)