diff mbox series

[PUSHED] gdb/remote: remove an out of date comment

Message ID 40578beee8a593e3668852238fd8e9f53790f2c9.1721662797.git.aburgess@redhat.com
State New
Headers
Series [PUSHED] gdb/remote: remove an out of date comment |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Andrew Burgess July 22, 2024, 3:40 p.m. UTC 
  A comment above an `if` check was accidentally left in place after
this commit:

  commit ddb3f3d89cf62df6be3cb9e110504def19625160
  Date:   Tue Mar 19 12:34:34 2024 +0100

      Add "error_message+" feature to qSupported

The comment relates to how 'E.msg' style remote replies are not
supported by every packet, but after the above commit they are
supported in all cases (that call packet_check_result), and the
comment should have been removed.
---
 gdb/remote.c | 3 ---
 1 file changed, 3 deletions(-)


base-commit: 6fc24c7607ba54a2fc3e2a947de26bc25d42cbe3
diff mbox series

Patch

diff --git a/gdb/remote.c b/gdb/remote.c
index efef5944ed5..0fd45cc96c9 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2532,9 +2532,6 @@  packet_check_result (const char *buf)
 	/* "Enn"  - definitely an error.  */
 	return packet_result::make_numeric_error (buf + 1);
 
-      /* Not every request accepts an error in a E.msg form.
-	 Some packets accepts only Enn, in this case E. is not
-	 defined and E. is treated as PACKET_OK.  */
       /* Always treat "E." as an error.  This will be used for
 	 more verbose error messages, such as E.memtypes.  */
       if (buf[0] == 'E' && buf[1] == '.')