From patchwork Mon Jun 13 17:58:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Taylor X-Patchwork-Id: 13045 Received: (qmail 107490 invoked by alias); 13 Jun 2016 17:58:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107475 invoked by uid 89); 13 Jun 2016 17:58:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=H*x:1.5, H*x:8.5, H*UA:8.5, HX-DKIM:OpenDKIM X-HELO: mailuogwdur.emc.com Received: from mailuogwdur.emc.com (HELO mailuogwdur.emc.com) (128.221.224.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 17:58:33 +0000 Received: from maildlpprd56.lss.emc.com (maildlpprd56.lss.emc.com [10.106.48.160]) by mailuogwprd53.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id u5DHwTCG030015 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 13 Jun 2016 13:58:30 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd53.lss.emc.com u5DHwTCG030015 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd53.lss.emc.com u5DHwTCG030015 Received: from mailapphubprd51.lss.emc.com (emcmail.lss.emc.com [10.106.83.170]) by maildlpprd56.lss.emc.com (RSA Interceptor) for ; Mon, 13 Jun 2016 13:58:12 -0400 Received: from usendtaylorx2l (d5170089.lss.emc.com [10.243.146.89]) by mailapphubprd51.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id u5DHwK8g006267; Mon, 13 Jun 2016 13:58:20 -0400 Received: by usendtaylorx2l (Postfix, from userid 26043) id 26A342614CD; Mon, 13 Jun 2016 13:58:19 -0400 (EDT) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l (Postfix) with ESMTP id E57A4260847; Mon, 13 Jun 2016 13:58:19 -0400 (EDT) From: David Taylor To: gdb-patches@sourceware.org cc: dtaylor@emc.com Subject: [PATCH] symtab.c -- Fix off by one allocation bug Date: Mon, 13 Jun 2016 13:58:19 -0400 Message-ID: <31327.1465840699@usendtaylorx2l> X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd53.lss.emc.com X-IsSubscribed: yes This fixes a problem found by valgrind. Applying this patch caused no regressions on GNU/Linux x86-64 and satisfied valgrind. * gdb/symtab.c (symbol_set_names): Fix off by one error in allocation. --- gdb/ChangeLog | 4 ++++ gdb/symtab.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9c09269..aaeeb6e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2016-06-09 David Taylor + + * symtab.c (symbol_set_names): Fix off by one error in allocation. + 2016-06-07 Simon Marchi * mi/mi-interp.c (mi_record_changed): Add missing braces. diff --git a/gdb/symtab.c b/gdb/symtab.c index f7a207a..12e1cf5 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -1010,7 +1010,7 @@ symbol_set_names (struct general_symbol_info *gsymbol, = ((struct demangled_name_entry *) obstack_alloc (&per_bfd->storage_obstack, offsetof (struct demangled_name_entry, demangled) - + lookup_len + demangled_len + 2)); + + lookup_len + demangled_len + 3)); mangled_ptr = &((*slot)->demangled[demangled_len + 1]); strcpy (mangled_ptr, lookup_name); (*slot)->mangled = mangled_ptr;