From patchwork Wed Jul 10 02:56:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 33645 Received: (qmail 126048 invoked by alias); 10 Jul 2019 02:56:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 126037 invoked by uid 89); 10 Jul 2019 02:56:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:sk:server- X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 02:56:29 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 74EE01EAAE; Tue, 9 Jul 2019 22:56:27 -0400 (EDT) Subject: Re: [PATCH 2/7] Arm: Create feature files for Arm target descriptions To: Alan Hayward , "gdb-patches@sourceware.org" Cc: nd References: <20190705094525.51536-1-alan.hayward@arm.com> <20190705094525.51536-3-alan.hayward@arm.com> From: Simon Marchi Message-ID: <2cf8ee69-f887-0a8b-91b0-d26eb2c3c9bc@simark.ca> Date: Tue, 9 Jul 2019 22:56:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190705094525.51536-3-alan.hayward@arm.com> On 2019-07-05 5:45 a.m., Alan Hayward wrote: > Add Arm to the list of feature target description targets and generate the > relevant C files. > > Add arm-m-profile-with-fpa.xml as the feature version of the exisiting > arm-with-m-fpa-layout.xml. > > Add extra comments to the Makefile for readability. > > New files are not yet used. Hi Alan, Note that you'll need to re-generate these files following the renaming of common to gdbsupport. It should not be a big deal though. However, when I try to re-generate the C files, I get this spurious diff: Do you see it too? If so, would you mind just pushing an obvious patch to fix it? This patch LGTM, at least the features/Makefile and target-descriptions.c parts (the arm parts look good too but I don't really know the specifics of the architecture). Thanks! Simon diff --git a/gdb/features/aarch64-pauth.c b/gdb/features/aarch64-pauth.c index 931e6cb28410..7bd73a6b21d9 100644 --- a/gdb/features/aarch64-pauth.c +++ b/gdb/features/aarch64-pauth.c @@ -11,6 +11,5 @@ create_feature_aarch64_pauth (struct target_desc *result, long regnum) feature = tdesc_create_feature (result, "org.gnu.gdb.aarch64.pauth"); tdesc_create_reg (feature, "pauth_dmask", regnum++, 1, NULL, 64, "int"); tdesc_create_reg (feature, "pauth_cmask", regnum++, 1, NULL, 64, "int"); - return regnum; }