From patchwork Thu Dec 27 14:08:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 30852 Received: (qmail 118022 invoked by alias); 27 Dec 2018 14:08:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117927 invoked by uid 89); 27 Dec 2018 14:08:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Google-Smtp-Source:sk:ALg8bN5, saving X-HELO: mail-wm1-f67.google.com Received: from mail-wm1-f67.google.com (HELO mail-wm1-f67.google.com) (209.85.128.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Dec 2018 14:08:52 +0000 Received: by mail-wm1-f67.google.com with SMTP id f81so17535441wmd.4 for ; Thu, 27 Dec 2018 06:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ifD2d/GdlgJnG54ybdeqNysRknTVbf04nzE8K0UxGvc=; b=NLDy0RwMeV+QSegqlTYhIMCCkfiPv66bNIMTqQ/hzKZ0nKPMCeYdtwzWUVr/AN4v3N udmul/f8CnJKqL44goJrRAdOSAxi1Dff9P/rUo5cjr/Tggg5s28OSBa5jQOz4KXEjYAV Koap0K82I/03cieOpnVYPvCYwSlDnv/AuvSbJYxMgArmk0ar6Dn6FmP/UsCh0Mh0vc1s vz23ofHk8hBZmNp5BcIDdFHTW9f6077tr9RrdEiXHKqdqXRAeVL4OnGU9c8MCMkTTX4a Is4F+q8i1XB5y5XnMtccb0WxpglWLpnyCRXt8i/LXpk8s/ieGshy4ZYQZ2/u8bctjDEy 9Ugg== Return-Path: Received: from localhost (host86-156-236-210.range86-156.btcentralplus.com. [86.156.236.210]) by smtp.gmail.com with ESMTPSA id g9sm22174766wmg.44.2018.12.27.06.08.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 06:08:49 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: alan.hayward@arm.com, abidh@codesourcery.com, Anton.Kolesov@synopsys.com, hp@axis.com, jamesb@excamera.com, vapier@gentoo.org, Andrew Burgess Subject: [PATCH 02/12] gdb/alpha: Use default gdbarch methods where possible Date: Thu, 27 Dec 2018 14:08:26 +0000 Message-Id: <240e1a7f878f5e027e05d3cb8c377bc4cbd161e4.1545918069.git.andrew.burgess@embecosm.com> In-Reply-To: References: In-Reply-To: References: X-IsSubscribed: yes Make use of the default gdbarch methods for gdbarch_dummy_id, and gdbarch_unwind_pc. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * gdb/alpha-tdep.c (alpha_dummy_id): Delete. (alpha_unwind_pc): Delete. (alpha_gdbarch_init): Don't register deleted functions with gdbarch. --- gdb/ChangeLog | 7 +++++++ gdb/alpha-tdep.c | 29 ----------------------------- 2 files changed, 7 insertions(+), 29 deletions(-) diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c index 91bbe06ebf7..77566bf625d 100644 --- a/gdb/alpha-tdep.c +++ b/gdb/alpha-tdep.c @@ -1463,29 +1463,6 @@ reinit_frame_cache_sfunc (const char *args, { reinit_frame_cache (); } - - -/* Assuming NEXT_FRAME->prev is a dummy, return the frame ID of that - dummy frame. The frame ID's base needs to match the TOS value - saved by save_dummy_frame_tos(), and the PC match the dummy frame's - breakpoint. */ - -static struct frame_id -alpha_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - ULONGEST base; - base = get_frame_register_unsigned (this_frame, ALPHA_SP_REGNUM); - return frame_id_build (base, get_frame_pc (this_frame)); -} - -static CORE_ADDR -alpha_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - ULONGEST pc; - pc = frame_unwind_register_unsigned (next_frame, ALPHA_PC_REGNUM); - return pc; -} - /* Helper routines for alpha*-nat.c files to move register sets to and from core files. The UNIQUE pointer is allowed to be NULL, as most @@ -1807,12 +1784,6 @@ alpha_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* Settings for calling functions in the inferior. */ set_gdbarch_push_dummy_call (gdbarch, alpha_push_dummy_call); - /* Methods for saving / extracting a dummy frame's ID. */ - set_gdbarch_dummy_id (gdbarch, alpha_dummy_id); - - /* Return the unwound PC value. */ - set_gdbarch_unwind_pc (gdbarch, alpha_unwind_pc); - set_gdbarch_inner_than (gdbarch, core_addr_lessthan); set_gdbarch_skip_trampoline_code (gdbarch, find_solib_trampoline_target);