From patchwork Wed Apr 15 21:34:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 6248 Received: (qmail 117032 invoked by alias); 15 Apr 2015 21:35:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 117018 invoked by uid 89); 15 Apr 2015 21:35:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-pa0-f73.google.com Received: from mail-pa0-f73.google.com (HELO mail-pa0-f73.google.com) (209.85.220.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Apr 2015 21:35:02 +0000 Received: by pablj1 with SMTP id lj1so4122387pab.0 for ; Wed, 15 Apr 2015 14:35:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:subject:in-reply-to :references; bh=ujs/mYQjJ5jVljD3sBsUtVvZrJjxlZbdQQAMS2pWg20=; b=CguIs64RR6pQrhPWgYCvV+FebLF8J/6DmXfVg+iB+j8fMr+QToYd5HfL512MILRHj9 3U4PFfuYbmlwENlu5b3pVnJmoyOP4C+RuxPk+7LBJdq62rqwbFzoIJKGjGt2qyQjf99i ANFtM/Rd44ob28z4FvykSeXLd7BKtp7LtsWUr14bCGTKWAZnJj37ES7iLhCHDQKkJR5n NfUME7SKxygJYl4oKDIS2j5S7KQ+q/QoIArQHaxl/8p7BmE1hUOsA98qPuKJESF72pRw 3YCSaHY4yspwMtNi4pbz6TDSExR9Y3/v/A/lIY/jioiZQTmAAEoDarZusM/iEZjjMua+ OJZQ== X-Gm-Message-State: ALoCoQmfL4s9u00u7v+6zQe/ZX+bdVocR58Us08uA0HdtTmXL8Z3LGszYWRbRWLMoAILDJFcyUFh7KP9d/UcVfGGWZjB8gXyXLs47zmFsYJ2Vng8EJEvzPFxjNs0DTWmXj1USAyzyYwqVzb03hZ7meDnl7ss3idWjtGWRaTzIYTlgwiY1KvdUyg= X-Received: by 10.66.97.10 with SMTP id dw10mr36508990pab.48.1429133700551; Wed, 15 Apr 2015 14:35:00 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id t22si226417yho.2.2015.04.15.14.35.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Apr 2015 14:35:00 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id jbQ7yY6e.1; Wed, 15 Apr 2015 14:35:00 -0700 From: Doug Evans MIME-Version: 1.0 Message-ID: <21806.55683.577616.55845@ruffy2.mtv.corp.google.com> Date: Wed, 15 Apr 2015 14:34:59 -0700 To: gdb-patches@sourceware.org Subject: Re: [PATCH] dwarf2read.c (dw2_expand_symtabs_matching): Add some QUIT calls. In-Reply-To: <21806.51621.699064.799001@ruffy2.mtv.corp.google.com> References: <21806.51621.699064.799001@ruffy2.mtv.corp.google.com> X-IsSubscribed: yes Doug Evans writes: > Doug Evans writes: > > Hi. > > > > "info fun foo" can be a pain when it's not interruptable, > > especially if you're not exactly sure of what you're looking for > > and provide something that matches too much. > > > > 2015-03-30 Doug Evans > > > > * dwarf2read.c (dw2_expand_symtabs_matching): Add some QUIT calls. > > Committed. Hi. I committed this corresponding patch. There is a call to QUIT in recursively_search_psymtabs, but I like the added symmetry and robustness. [The astute reader may find that there are already QUIT calls that can catch ^c's in this case. E.g., dwarf2read.c calls out to c_print_type (IIRC) which has a call to QUIT within it. However, there is a problem here which I still have to address: these QUIT calls can leave symbol tables partially constructed. Not sure how to fix this yet (I can think of a couple of ways), and at any rate I like the explicit QUIT calls that these two patches add.] 2015-04-15 Doug Evans * psymtab.c (psym_expand_symtabs_matching): Add QUIT call. diff --git a/gdb/psymtab.c b/gdb/psymtab.c index b3c2f44..383e4c4 100644 --- a/gdb/psymtab.c +++ b/gdb/psymtab.c @@ -1423,6 +1423,8 @@ psym_expand_symtabs_matching ALL_OBJFILE_PSYMTABS_REQUIRED (objfile, ps) { + QUIT; + if (ps->readin) continue;