From patchwork Wed Aug 27 16:46:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 2556 Received: (qmail 6811 invoked by alias); 27 Aug 2014 16:46:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 6799 invoked by uid 89); 27 Aug 2014 16:46:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f202.google.com Received: from mail-pd0-f202.google.com (HELO mail-pd0-f202.google.com) (209.85.192.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 16:46:39 +0000 Received: by mail-pd0-f202.google.com with SMTP id w10so115589pde.5 for ; Wed, 27 Aug 2014 09:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=rbX4W1Sr9e+QZkl+qrPy0rsoCSuHPW/htc48BHNmihI=; b=b8gsfqwv1QQyAaGIpZLV2/nRvMuq2Fhuzz6jM7y8uieAqAKHflllRBfS7MCJ+MOXpA 8+tixJ59OBOTcNPBFItqi8AEkRIxmr2n/F6TJzNbwa7XSNJ6YOuCqhXFivTfEh1fla/1 pEmLKTx7PKUNkUKS6yERLchhXwUiJQg+8SsYwasCOoT5IEECUx7T7ln2xUAwvPXaVz68 ITRej61aNyBXDT69CgdtrZpZXvJdtl2ljzQHczU+sSCp9U0MmJudmODCQf2h1z9f85v7 uLS6D2CSJ8uumgA1mLsZEVq2iEyI5bgsEZ0HA3dpsw42Lw9zE+ofKI/K0khkDK8cbts1 tj7A== X-Gm-Message-State: ALoCoQna99zShEA7O/OWX0b2D6YpxyzIsV1OlIKdi4OK9qJrOqJeKI+ie6QDLLJ8jl97j0baqvaa X-Received: by 10.68.190.130 with SMTP id gq2mr22495476pbc.3.1409157997006; Wed, 27 Aug 2014 09:46:37 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id c77si60757yha.5.2014.08.27.09.46.36 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Aug 2014 09:46:36 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 6CD3931C18E; Wed, 27 Aug 2014 09:46:36 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Message-ID: <21502.2923.780309.118256@ruffy2.mtv.corp.google.com> Date: Wed, 27 Aug 2014 09:46:35 -0700 To: gdb-patches@sourceware.org cc: dblaikie@gmail.com Subject: Re: [PATCH] Add clang support to gdb_compile_shlib In-Reply-To: References: X-IsSubscribed: yes Doug Evans writes: > Hi. > > This patch fixes several more failures in the testsuite when run with clang. > > gdb.base/ > pending.exp > fixsection.exp > shlib-call.exp > shreloc.exp > solib-display.exp > solib-nodir.exp > solib-search.exp > solib-symbol.exp > > 2014-08-25 Doug Evans > > * lib/gdb.exp (gdb_compile_shlib): Add support for clang. > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 61e1614..fc9b1df 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -2947,6 +2947,9 @@ proc gdb_compile_shlib {sources dest options} { > "xlc-*" { > lappend obj_options "additional_flags=-qpic" > } > + "clang-*" { > + lappend obj_options "additional_flags=-fpic" > + } > "gcc-*" { > if { !([istarget "powerpc*-*-aix*"] > || [istarget "rs6000*-*-aix*"] Hi. A colleague checked windows and got warnings that -fpic is a no-op, so I've pushed this patch. [I debated combining clang with gcc, I can go either way. If it's important to people at this particular point in time I'm happy to do so.] 2014-08-27 Doug Evans * lib/gdb.exp (gdb_compile_shlib): Add support for clang. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 61e1614..1019ecd 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2947,6 +2947,12 @@ proc gdb_compile_shlib {sources dest options} { "xlc-*" { lappend obj_options "additional_flags=-qpic" } + "clang-*" { + if { !([istarget "*-*-cygwin*"] + || [istarget "*-*-mingw*"]) } { + lappend obj_options "additional_flags=-fpic" + } + } "gcc-*" { if { !([istarget "powerpc*-*-aix*"] || [istarget "rs6000*-*-aix*"]