From patchwork Mon Aug 31 18:51:42 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 142544 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F7364BA903A for ; Mon, 31 Aug 2026 18:53:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F7364BA903A X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8A1FF4BA2E38 for ; Mon, 31 Aug 2026 18:53:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A1FF4BA2E38 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8A1FF4BA2E38 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788202386; cv=none; b=cfxbJhceuO765+7Q9d4VF3WSnzYEZUY7/hd2PR5paRyAsX63RIXE/isj6sY1k3WANqZikFE1yD/owaWI+2FdkWu2GEHnTZq1SbDkJlKNftBeXigRfgwLoxT3o616cZCrVK3vNMuQdv9Y6Iv/PqzIMk7sdq9eOoOgrdIfbTYeTB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788202386; c=relaxed/simple; bh=LFmS0SVDAgop4SUpz2aUbnWF9BIX4/HUBi+ot1wUty8=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=cYHKZpR3sYfcNa6rDtr1KnlXAnoSmfSeLSyWl5ZElsWVDO6hxW/j0m4nC5nXw0ifkS08pdsph4AqnpUiGshF6C7EGb4Pn6Z/BhdLLJu5+9gfX7zjCc2rV6y86jdf08dVtxqZpbjuQ/UeJ117R2/nKU2tCGETnx58MIYnMOkBS5M= ARC-Authentication-Results: i=1; sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A1FF4BA2E38 Received: by simark.ca (Postfix) id 3AE101E167; Mon, 31 Aug 2026 14:53:05 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 3/7] gdbserver: fix missing dependency tracking for gdbreplay.o Date: Mon, 31 Aug 2026 14:51:42 -0400 Message-ID: <20260831185300.572297-4-simon.marchi@efficios.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831185300.572297-1-simon.marchi@efficios.com> References: <20260831185300.572297-1-simon.marchi@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1165.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, LOCAL_AUTHENTICATION_FAIL_DMARC, LOCAL_AUTHENTICATION_FAIL_SPF, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The rule for gdbreplay.o uses $(COMPILE.post), which makes the compiler write the dependencies to $(DEPDIR)/gdbreplay.Tpo, but it does not run $(POSTCOMPILE), which is what renames the .Tpo file to .Po. After building gdbreplay, we are left with: $ make gdbreplay CXX gdbreplay.o CXX utils.o GEN version-generated.cc CXX version.o CXXLD gdbreplay /0.1s $ ls -1 .deps gdbreplay.Tpo utils.Po version.Po This means that a change in a header file included by gdbreplay.cc will not cause a rebuild. Add the missing $(POSTCOMPILE) invocation. Change-Id: Iea5ca939cf30a0fe892ed3d2c224d22f227f0272 --- gdbserver/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in index b06e0b86e45b..3a3c8e62d14f 100644 --- a/gdbserver/Makefile.in +++ b/gdbserver/Makefile.in @@ -592,6 +592,7 @@ target/%.o: ../gdb/target/%.c gdbreplay.o: gdbreplay.cc $(ECHO_CXX) $(COMPILE.pre) $(INTERNAL_CFLAGS) $(CXXFLAGS) \ -include gdbsupport/common-defs.h $(COMPILE.post) $< + $(POSTCOMPILE) # # Dependency tracking.