diff mbox series

[REPOST] H8/300: sim: testsuite: Use the correct file descriptor for stdout

Message ID 20260827083334.1637356-1-jdx@o2.pl
State New
Headers
Series [REPOST] H8/300: sim: testsuite: Use the correct file descriptor for stdout |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Jan Dubiec Aug. 27, 2026, 8:31 a.m. UTC 
  This is obviously a typo, because the file descriptor for stdout is 1
on both Linux and Windows. As a result, the test cases returned nothing
on Windows, i.e. neither "pass" nor "fail".

It works on Linux, however, because file descriptors 0-2 usually all
refer to the same underlying device, which is opened for bidirectional
I/O. File descriptor 1 may be line- or block-buffered by libc, but once
the data is actually written to the kernel, it ultimately goes to the
same underlying bidirectional pseudo-terminal device.
---
 sim/testsuite/h8300/testutils.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Tromey Sept. 3, 2026, 4:59 p.m. UTC | #1 
>>>>> "Jan" == Jan Dubiec <jdx@o2.pl> writes:

Jan> This is obviously a typo, because the file descriptor for stdout is 1
Jan> on both Linux and Windows. As a result, the test cases returned nothing
Jan> on Windows, i.e. neither "pass" nor "fail".

Jan> It works on Linux, however, because file descriptors 0-2 usually all
Jan> refer to the same underlying device, which is opened for bidirectional
Jan> I/O. File descriptor 1 may be line- or block-buffered by libc, but once
Jan> the data is actually written to the kernel, it ultimately goes to the
Jan> same underlying bidirectional pseudo-terminal device.

LGTM.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/sim/testsuite/h8300/testutils.inc b/sim/testsuite/h8300/testutils.inc
index 63d27d45c14..1e2c7c31c7b 100644
--- a/sim/testsuite/h8300/testutils.inc
+++ b/sim/testsuite/h8300/testutils.inc
@@ -85,7 +85,7 @@  _main:
 
 ; Output "pass\n"
 	.macro pass
-	mov.w	#0, r0		; fd == stdout
+	mov.w	#1, r0		; fd == stdout
 .if (sim_cpu == h8300)
 	mov.w	#pass_str, r1	; buf == "pass\n"
 	mov.w	#5, r2		; len == 5
@@ -98,7 +98,7 @@  _main:
 
 ; Output "fail\n"
 	.macro fail
-	mov.w	#0, r0		; fd == stdout
+	mov.w	#1, r0		; fd == stdout
 .if (sim_cpu == h8300)
 	mov.w	#fail_str, r1	; buf == "fail\n"
 	mov.w	#5, r2		; len == 5