[2/2,gdb/testsuite] Fix gdb.python/py-section-script.exp with older objdump
Checks
| Context |
Check |
Description |
| linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Build passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Test passed
|
| linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Test passed
|
Commit Message
On AlmaLinux 9.8 ppc64le with objdump 2.35.2 I run into:
...
ERROR: tcl error sourcing gdb/testsuite/gdb.python/py-section-script.exp.
ERROR: tcl error code CHILDSTATUS 3614626 1
ERROR: objdump: unrecognized option '--decompress'
...
Fix this by using remote_exec instead of exec, and checking the result.
Tested on x86_64-linux and ppc64le-linux.
---
.../gdb.python/py-section-script.exp | 21 ++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
@@ -65,9 +65,24 @@ foreach_with_prefix variant {plain compressed} {
if {$variant == "compressed"} {
set objdump_program [gdb_find_objdump]
- set debug_sect [exec $objdump_program -j .debug_gdb_scripts -s "$the_binfile"]
- set debug_sect_decompressed [exec $objdump_program -j .debug_gdb_scripts \
- -s "$the_binfile" --decompress]
+
+ set res \
+ [remote_exec host \
+ "$objdump_program -j .debug_gdb_scripts -s \"$the_binfile\""]
+ if {[lindex $res 0] != 0} {
+ unsupported "Couldn't run objdump"
+ return
+ }
+ set debug_sect [lindex $res 1]
+
+ set res \
+ [remote_exec host \
+ "$objdump_program -j .debug_gdb_scripts -s \"$the_binfile\" --decompress"]
+ if {[lindex $res 0] != 0} {
+ unsupported "Couldn't run objdump --decompress"
+ return
+ }
+ set debug_sect_decompressed [lindex $res 1]
if {$debug_sect == $debug_sect_decompressed} {
fail ".debug_gdb_scripts in $the_binfile is not compressed"