diff mbox series

[1/9] Drop executable mode in some files

Message ID	20260603100516.144737-2-tdevries@suse.de
State	Committed
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7B824BA2E09 From: Tom de Vries <tdevries@suse.de> To: gdb-patches@sourceware.org Subject: [PATCH 1/9] [gdb] Drop executable mode in some files Date: Wed, 3 Jun 2026 12:05:08 +0200 Message-ID: <20260603100516.144737-2-tdevries@suse.de> In-Reply-To: <20260603100516.144737-1-tdevries@suse.de> References: <20260603100516.144737-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] Precedence: list Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org
Series	Make gdb dir codespell-clean \| [0/9] Make gdb dir codespell-clean [1/9] Drop executable mode in some files [2/9,gdb/contrib] Describe words in codespell-ignore-words.txt [3/9,gdb/contrib] Extend codespell-ignore-words.txt [4/9] Fix typos [5/9] Fix codespell false positives by ignoring [6/9] Fix codespell false positive by string splitting [7/9] Fix codespell false positives by renaming [8/9,pre-commit] Include gdb in codespell check [9/9,pre-commit] Simplify codespell configuration

Checks

Context	Check	Description
linaro-tcwg-bot/tcwg_gdb_build--master-arm	success	Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64	success	Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm	success	Test passed

Commit Message

Tom de Vries June 3, 2026, 10:05 a.m. UTC

  During a review, Claude Code noticed that gdb/amd64-tdep.c has executable
mode.

This was added by accident in commit f9aa48dc545 ("gdb, amd64: extend the
amd64 prologue analyzer to skip register pushes").

Fix this, and similar problems in other files.
---
 gdb/amd64-tdep.c                                      | 0
 gdb/testsuite/gdb.arch/amd64-lam.c                    | 0
 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c   | 0
 gdb/testsuite/gdb.base/jump_multiple_objfiles.c       | 0
 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp     | 0
 gdb/testsuite/gdb.base/jump_multiple_objfiles.h       | 0
 gdb/testsuite/gdb.btrace/exception.exp                | 0
 gdb/testsuite/gdb.fortran/nested-funcs.exp            | 0
 gdb/testsuite/gdb.fortran/nested-funcs.f90            | 0
 gdb/testsuite/gdb.fortran/oop_extend_type.exp         | 0
 gdb/testsuite/gdb.fortran/oop_extend_type.f90         | 0
 gdb/testsuite/gdb.fortran/print_type.exp              | 0
 gdb/testsuite/gdb.fortran/vla-type.exp                | 0
 gdb/testsuite/gdb.fortran/vla-type.f90                | 0
 gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb | 0
 gdb/testsuite/lib/compiler.cc                         | 0
 16 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 gdb/amd64-tdep.c
 mode change 100755 => 100644 gdb/testsuite/gdb.arch/amd64-lam.c
 mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c
 mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.c
 mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.base/jump_multiple_objfiles.h
 mode change 100755 => 100644 gdb/testsuite/gdb.btrace/exception.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/nested-funcs.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/nested-funcs.f90
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/oop_extend_type.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/oop_extend_type.f90
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/print_type.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/vla-type.exp
 mode change 100755 => 100644 gdb/testsuite/gdb.fortran/vla-type.f90
 mode change 100755 => 100644 gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb
 mode change 100755 => 100644 gdb/testsuite/lib/compiler.cc

Comments

Simon Marchi June 4, 2026, 8:05 p.m. UTC | #1

On 6/3/26 6:05 AM, Tom de Vries wrote:
> During a review, Claude Code noticed that gdb/amd64-tdep.c has executable
> mode.
> 
> This was added by accident in commit f9aa48dc545 ("gdb, amd64: extend the
> amd64 prologue analyzer to skip register pushes").
> 
> Fix this, and similar problems in other files.

Since I had the exact same patch:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

Tom de Vries June 4, 2026, 8:07 p.m. UTC | #2

On 6/4/26 10:05 PM, Simon Marchi wrote:
> On 6/3/26 6:05 AM, Tom de Vries wrote:
>> During a review, Claude Code noticed that gdb/amd64-tdep.c has executable
>> mode.
>>
>> This was added by accident in commit f9aa48dc545 ("gdb, amd64: extend the
>> amd64 prologue analyzer to skip register pushes").
>>
>> Fix this, and similar problems in other files.
> 
> Since I had the exact same patch:
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 

Pushed, thanks.

- Tom

> Simon

diff mbox series

Patch

diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.arch/amd64-lam.c b/gdb/testsuite/gdb.arch/amd64-lam.c
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c b/gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.base/jump_multiple_objfiles.c b/gdb/testsuite/gdb.base/jump_multiple_objfiles.c
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.base/jump_multiple_objfiles.exp b/gdb/testsuite/gdb.base/jump_multiple_objfiles.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.base/jump_multiple_objfiles.h b/gdb/testsuite/gdb.base/jump_multiple_objfiles.h
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.btrace/exception.exp b/gdb/testsuite/gdb.btrace/exception.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/nested-funcs.exp b/gdb/testsuite/gdb.fortran/nested-funcs.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/nested-funcs.f90 b/gdb/testsuite/gdb.fortran/nested-funcs.f90
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/oop_extend_type.exp b/gdb/testsuite/gdb.fortran/oop_extend_type.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/oop_extend_type.f90 b/gdb/testsuite/gdb.fortran/oop_extend_type.f90
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/print_type.exp b/gdb/testsuite/gdb.fortran/print_type.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/vla-type.exp b/gdb/testsuite/gdb.fortran/vla-type.exp
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.fortran/vla-type.f90 b/gdb/testsuite/gdb.fortran/vla-type.f90
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb b/gdb/testsuite/gdb.testsuite/gdb_test_multiple-lbl.gdb
old mode 100755
new mode 100644
diff --git a/gdb/testsuite/lib/compiler.cc b/gdb/testsuite/lib/compiler.cc
old mode 100755
new mode 100644