From patchwork Tue May 26 14:57:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?S=C3=A9bastien_Darche?= X-Patchwork-Id: 135745 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 131D24BA799E for ; Tue, 26 May 2026 14:57:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 131D24BA799E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=X9iYFjkA X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtpout.efficios.com (smtpout.efficios.com [IPv6:2607:5300:400:ed00::31e5]) by sourceware.org (Postfix) with ESMTPS id E6D3D4BA2E3D for ; Tue, 26 May 2026 14:57:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6D3D4BA2E3D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E6D3D4BA2E3D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:5300:400:ed00::31e5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779807424; cv=none; b=QiY2fgWBMKqY/NPMRCP8cPCAXFa1F4x189tz8AY0uAp/85iu7r/qXXxQQoz4UEaklA/XIcmvFeGc14ZgTrqqXFtXUr+0fUiVL0xqJjNj3YjBhxPNdvT6AYTNSpAdkv+Bz6R383KOqoFN/H0hui7S3iUl7Ti39P16RsScMx9hb4I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779807424; c=relaxed/simple; bh=XgwyMWdK3cnc/mlk7mIdEqqkZej9lP0G4g5UNHdADpc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fDqYMw6cMa49wp3S9eOQKDCudcuJISoYYwzvkdw5u0senr3zbE7sRTj9g6MgtJq70U9uK+GUcG19CwZr1uVkLClPfKn2eJs6WKGgPdYQZpzYgbK2jdIkAx2eYms4dDrEyG6ei2bsauO3TnNUQoogBnHNQ+FM7i2AG10PCAeTV+I= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=X9iYFjkA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E6D3D4BA2E3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1779807423; bh=3Vl3Yhzm0maNpjLQE91VcyX18lkHNIWq37/0nZhigy8=; h=From:To:Cc:Subject:Date:From; b=X9iYFjkAJUuttXg45VzTQRJOb85h6Pm/QXMP8mMxwzSQ2MukbK50zVu+4PMEWbZzO cP0rEHLRnUwOYPKWE/aoNj0cFHdo1YEBfafnJAMhio4tvV5N+8sQ72nLyT+zGKCsGp ZNLtImu4JU0AbuSuiegZCp2wcFi4zXYDFPD39J4Y0pZl9wGbMV136D6evoTMOUclse HjjyiJVIvVF1r7JHi7xiQ4MiaicFlXX+2Sk6hgN5LdqMKqRli/47DOlurov4fDP/If sBTFDn/n1tH5baGAxINP5Y6IOVIXFGCSRBvxk30FlKb+sRp0U3jjEcBVseahvKPITW wg47wy7OWkrpQ== Received: from smtpout01.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4gPwnq2pkVzB0f for ; Tue, 26 May 2026 10:57:03 -0400 (EDT) Received: from sebastien-framework.internal.efficios.com (unknown [172.24.0.11]) by smtpout01.internal.efficios.com (Postfix) with ESMTP id F1DB42C8D6; Tue, 26 May 2026 10:57:02 -0400 (EDT) From: =?utf-8?q?S=C3=A9bastien_Darche?= To: gdb-patches@sourceware.org Cc: =?utf-8?q?S=C3=A9bastien_Darche?= Subject: [PATCH] gdb/breakpoint: remove assertion when printing internal breakpoints without locspecs Date: Tue, 26 May 2026 10:57:01 -0400 Message-ID: <20260526145701.41678-1-sdarche@efficios.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, PROLO_LEO1, RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org When debugging gdb with `set debug breakpoint on`, gdb would crash if the inferior happened to unload (through dlclose ()) a shared library that contains jit debugging symbols: ../../gdb/breakpoint.c:6473: internal-error: print_breakpoint_location: Assertion `b->locspec != nullptr || (!user_breakpoint_p (b) && (b->type == bp_shlib_event || b->type == bp_thread_event))' failed. A problem internal to GDB has been detected [...] This assertion was added in commit 5770f68 ("gdb: handle empty locspec when printing breakpoints"). The assumption for this assert is that the user may not call any (gdb-)debugging command between the time a shared library is marked (bp_location->shlib_disabled is set) and the breakpoint is actually removed. This would be true if the user called `maint info breakpoints` as explained in the original commit message. However, if `set debug breakpoint on` is called, gdb prints debugging info as the shared library is being unloaded. The ~jiter_objfile_data dtor deletes the breakpoint, which calls remove_breakpoint_1 on the bp_location in the recently unloaded shared object. Since `debug breakpoint` is enabled, we go through print_breakpoint_location with the bp_location's shlib_disabled flag set.. which results in the assert above. This commit removes the assertion as it is not true in all cases. I've also included a minimal test case that loads a shared library with a __jit_debug_register_code symbol. The test fails with the assert. Change-Id: Ia19c84f194a6f0c10315548c7f423bfd86ef0266 --- gdb/breakpoint.c | 17 --------- gdb/testsuite/gdb.base/jit-unload-solib.c | 21 +++++++++++ gdb/testsuite/gdb.base/jit-unload.c | 45 +++++++++++++++++++++++ gdb/testsuite/gdb.base/jit-unload.exp | 44 ++++++++++++++++++++++ 4 files changed, 110 insertions(+), 17 deletions(-) create mode 100644 gdb/testsuite/gdb.base/jit-unload-solib.c create mode 100644 gdb/testsuite/gdb.base/jit-unload.c create mode 100644 gdb/testsuite/gdb.base/jit-unload.exp diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 101dc57ee6b..85c4ffc3171 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -6457,23 +6457,6 @@ print_breakpoint_location (const breakpoint *b, const bp_location *loc) } else { - /* Internal breakpoints don't have a locspec string, but can become - pending if the shared library the breakpoint is in is unloaded. - For most internal breakpoint types though, after unloading the - shared library, the breakpoint will be deleted and never recreated - (see internal_breakpoint::re_set). But for two internal - breakpoint types bp_shlib_event and bp_thread_event this is not - true. Usually we don't expect the libraries that contain these - breakpoints to ever be unloaded, but a buggy inferior might do - such a thing, in which case GDB should be prepared to handle this - case. - - If these two breakpoint types become pending then there will be no - locspec string. */ - gdb_assert (b->locspec != nullptr - || (!user_breakpoint_p (b) - && (b->type == bp_shlib_event - || b->type == bp_thread_event))); const char *locspec_str = (b->locspec != nullptr ? b->locspec->to_string () : ""); uiout->field_string ("pending", locspec_str); diff --git a/gdb/testsuite/gdb.base/jit-unload-solib.c b/gdb/testsuite/gdb.base/jit-unload-solib.c new file mode 100644 index 00000000000..3cf2c580320 --- /dev/null +++ b/gdb/testsuite/gdb.base/jit-unload-solib.c @@ -0,0 +1,21 @@ +/* This test program is part of GDB, the GNU debugger. + + Copyright 2026 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* This simulates a JIT library. */ + + +#include "jit-protocol.h" diff --git a/gdb/testsuite/gdb.base/jit-unload.c b/gdb/testsuite/gdb.base/jit-unload.c new file mode 100644 index 00000000000..def66b53861 --- /dev/null +++ b/gdb/testsuite/gdb.base/jit-unload.c @@ -0,0 +1,45 @@ +/* This test program is part of GDB, the GNU debugger. + + Copyright 2026 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* Simulate loading of a library JIT code. */ + +#include +#include + +#ifdef __WIN32__ +#include +#define dlopen(name, mode) LoadLibrary (TEXT (name)) +#define dlclose(handle) FreeLibrary (handle) +#else +#include +#endif + + +int +main() +{ + void *handle = dlopen (SHLIB_NAME, RTLD_NOW); + + if (handle == nullptr) + { + fprintf (stderr, "%s\n", dlerror ()); + exit (1); + } + + dlclose (handle); + return 0; +} diff --git a/gdb/testsuite/gdb.base/jit-unload.exp b/gdb/testsuite/gdb.base/jit-unload.exp new file mode 100644 index 00000000000..0bf9c59385d --- /dev/null +++ b/gdb/testsuite/gdb.base/jit-unload.exp @@ -0,0 +1,44 @@ +# Copyright 2026 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This test checks that gdb does not assert when unloading a shared library +# that defines a __jit_debug_register_code if `set debug breakpoint on` is set. + +require allow_shlib_tests + +standard_testfile .c -solib.c +set libfile ${testfile}-lib + +set options [list \ + debug \ + shlib_load \ + additional_flags=-DSHLIB_NAME=\"${libfile}\"] + +if { [build_executable "build main file" $testfile $srcfile $options] == -1 } { + return +} + +if { [build_executable "build shlib" $libfile $srcfile2 {debug shlib}] == -1 } { + return +} + +clean_restart $::testfile + +if { ![runto_main] } { + return +} + +gdb_test_no_output "set debug breakpoint on" +gdb_continue_to_end "unload" continue 1