From patchwork Wed May 20 18:19:28 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 135363 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B34774BB5930 for ; Wed, 20 May 2026 18:21:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B34774BB5930 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=WMke6f5R X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 84E994BA23EC for ; Wed, 20 May 2026 18:21:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84E994BA23EC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84E994BA23EC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779301269; cv=none; b=mq8o6pUUUkd5sz9hpTeZ5nf1hnXI/alXq8YzsRwZj70XbjeACI7S1i9e1/8SVBHinLYw88B83S9ldA9gQYN/yoDa5mcS9SKB/FVOeySG4nCTlMhvXXMsm8ld1g7VsRxYrNlcG0WQHpjykdKZYanExI7+4wAQS/rFyQ2T6g13EsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779301269; c=relaxed/simple; bh=M3ToXCkZYYh5vgjUGx1RtVxZ5j7jAxh725009MMKTbU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=fsBFFgwIOQpWr/bJ6Ki9X8ABGbFNjTxgPs5eNyFGx8b5TugnezsXRUAWjCAao7FO37mY7fGNg1of0HWOW4dbKYzQxUp1caSXE2MLSa6PBapuaQ+GMBrPxqhjRS6kjNbHgeZY8h6apFsicgDIkOXv19E8/6b4V1lh6DUIYaHwuUk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=WMke6f5R DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84E994BA23EC Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 64KIL3QF182772 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 May 2026 14:21:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 64KIL3QF182772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1779301268; bh=HCmtiLotmYUiSXPOY2CoUj5Qf3uJR1C1p72pKZF5ei0=; h=From:To:Cc:Subject:Date:From; b=WMke6f5RR2uForFQOnkyw2zhTnSOjw5B8a0v8EJvRf/GovwHtJrSdNG9CqyZ7s2VR 5+zObm8V5YIrYmGgiXRCLoISqaCo8xdLdevSEi99JK0DYyyxA7lIadlfqJz/vBY9Vc wHAhIg/XbjKVre29jvFGbfHR1+9ge3w8xHua2g0RnxhYBwP5RSuhEsrGU69vcZaBMG 1NZmWFceGED3xW7guUwgrq6Iex19jPkDJ/4XrRvE1Fs3mnWijRatVzSl8A4UqYDS57 0Cwe5B+szbIg9dAHo/ZayMExVwKNJosXn/fV9y2/18860yFDSOw0YkEG6PYGvqHwV7 v4CVGgVGKPWvQ== Received: by simark.ca (Postfix) id 935CD1E024; Wed, 20 May 2026 14:21:03 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/2] gdb/dwarf: change signatured_type_up to include deleter type Date: Wed, 20 May 2026 14:19:28 -0400 Message-ID: <20260520182101.4074675-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 20 May 2026 18:21:03 +0000 X-Spam-Status: No, score=-3034.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org From: Simon Marchi We currently have: using dwarf2_per_cu_up = std::unique_ptr; using signatured_type_up = std::unique_ptr; Meaning that it's not possible to pass a signatured_type_up as a dwarf2_per_cu_up, even though the target types are related (it is possible to pass a `signatured_type *` as a `dwarf2_per_cu *`). If we give signatured_type_up the same deleter as dwarf2_per_cu_up, then it becomes possible to pass a signatured_type_up as a dwarf2_per_cu_up. This lets us avoid releasing a signatured_type_up only to create a dwarf2dwarf2_per_cu_up immediately after in some spots. The only downside is that we can't use make_unique anymore, but it's already the case for dwarf2_per_cu_up. Swap the order of things in add_type_unit so that we don't need a special holder variable. Change-Id: Iee34e5d1711d601297f109e58cbaeccb5a0c6cde --- gdb/dwarf2/read-debug-names.c | 2 +- gdb/dwarf2/read-gdb-index.c | 2 +- gdb/dwarf2/read.c | 19 ++++++++----------- gdb/dwarf2/read.h | 3 ++- 4 files changed, 12 insertions(+), 14 deletions(-) base-commit: ba415df8ba3817ab6eb5c9ec441ed2d979abe3b1 diff --git a/gdb/dwarf2/read-debug-names.c b/gdb/dwarf2/read-debug-names.c index 30ad0b21f2da..dfa54f7914a2 100644 --- a/gdb/dwarf2/read-debug-names.c +++ b/gdb/dwarf2/read-debug-names.c @@ -1036,7 +1036,7 @@ create_foreign_type_units_from_debug_names (dwarf2_per_bfd *per_bfd, map.foreign_type_units.emplace_back (sig_type.get ()); per_bfd->signatured_types.emplace (sig_type.get ()); - per_bfd->all_units.emplace_back (sig_type.release ()); + per_bfd->all_units.emplace_back (std::move (sig_type)); } } diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 48d1200270be..e0f527b7503e 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -584,7 +584,7 @@ create_signatured_type_table_from_gdb_index sig_types_hash.emplace (sig_type.get ()); units.emplace_back (sig_type.get ()); - per_bfd->all_units.emplace_back (sig_type.release ()); + per_bfd->all_units.emplace_back (std::move (sig_type)); } per_bfd->signatured_types = std::move (sig_types_hash); diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index f8ade564b0ba..883b068ad8ae 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -1440,9 +1440,8 @@ dwarf2_per_bfd::allocate_signatured_type (dwarf2_section_info *section, ULONGEST signature) { gdb_assert (section != nullptr); - auto result - = std::make_unique (this, section, sect_off, length, - is_dwz, signature); + signatured_type_up result (new signatured_type (this, section, sect_off, + length, is_dwz, signature)); result->index = all_units.size (); this->num_type_units++; return result; @@ -1453,10 +1452,9 @@ dwarf2_per_bfd::allocate_signatured_type (dwarf2_section_info *section, signatured_type_up dwarf2_per_bfd::allocate_signatured_type (ULONGEST signature) { - auto result - = std::make_unique (this, nullptr, - invalid_sect_offset, - 0, false, signature); + signatured_type_up result (new signatured_type (this, nullptr, + invalid_sect_offset, 0, + false, signature)); result->index = all_units.size (); this->num_type_units++; return result; @@ -2244,13 +2242,12 @@ add_type_unit (dwarf2_per_bfd *per_bfd, dwarf2_section_info *section, if (per_bfd->all_units.size () == per_bfd->all_units.capacity ()) ++per_bfd->tu_stats.nr_all_type_units_reallocs; - signatured_type_up sig_type_holder + signatured_type_up sig_type = per_bfd->allocate_signatured_type (section, sect_off, length, false /* is_dwz */, sig); - signatured_type *sig_type = sig_type_holder.get (); - per_bfd->all_units.emplace_back (sig_type_holder.release ()); - auto emplace_ret = per_bfd->signatured_types.emplace (sig_type); + auto emplace_ret = per_bfd->signatured_types.emplace (sig_type.get ()); + per_bfd->all_units.emplace_back (std::move (sig_type)); /* Assert that an insertion took place - that there wasn't a type unit with that signature already. */ diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h index 12dc6224d8c0..fd6ee1b8b800 100644 --- a/gdb/dwarf2/read.h +++ b/gdb/dwarf2/read.h @@ -504,7 +504,8 @@ struct signatured_type : public dwarf2_per_cu dwarf2_per_cu *hint_per_cu = nullptr; }; -using signatured_type_up = std::unique_ptr; +using signatured_type_up + = std::unique_ptr; /* See dwarf2_per_cu declaration. */