From patchwork Mon May 18 18:33:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Bouhaouel, Mohamed" X-Patchwork-Id: 135223 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2AD494BB3B8B for ; Mon, 18 May 2026 18:35:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AD494BB3B8B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=fhDLptZn X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by sourceware.org (Postfix) with ESMTPS id 457844BABF3D for ; Mon, 18 May 2026 18:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 457844BABF3D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 457844BABF3D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=192.198.163.15 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779129289; cv=none; b=XRKXUHCmyBfsXb17dq8OWJg4Y+Q4dYppoUUL2ERvrXTkIxojo3IKrVrcWT46KfwCI0yo8w0twiu5krmLBvK9ro7vFU9xeTQLJ7KlKkQ0aK4SyjXGdIthEaiD/xkycwjnQaWElcKyKaMFfb1mqjqhAvR96ZH/uAPr0kyG/hqqfUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779129289; c=relaxed/simple; bh=C2L5+weIPh3efjjXZaQhVPwyUrVN21mkxaYZ8ribkSA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZkITSUzycgoPm+bN3LdofxRPt5DcytEabLGlBOHJhpZigYCJ26dGkGV5oBI0+dt+QqiLXhR7tvEy4Pw/7os24gxHUHAlmf7f0GuszzBbkvQddbZvGPSrSkQ3ummfzrJMv8HZXUbDofaelkuukCwwrR2rXpmlrsvSgsuvG4VTXYk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=fhDLptZn DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 457844BABF3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779129284; x=1810665284; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=C2L5+weIPh3efjjXZaQhVPwyUrVN21mkxaYZ8ribkSA=; b=fhDLptZnhzwA5vd41bIm/aL7lEFulyCTShU3HdWjJ7K6QgdHfvDEkpgy cs0A+/K37ukxpKojnX5yfhWJHwjent7H6m0vyW2OWSqVRhA4j9PVNJZwJ kzEl4uYIs8mE27EvZT1YeNvH+92gcIVmIdkVa5xvuI/4/8tglswv83pxP xYM8tnzVkGfCGe+PVmaG4kY9B2OzRqey9qBE+Gx7aCKe852ljx46WwR9Q oxFya1BP8SGo8JJ7hfP/63KMUmIf6CAmuCZSc5LYaP2zzpaGDhAxhLBlM PADtMLkg2g7alv3mQx6fWfOK8V+nKvdrL+1JztuHf+TjJsXp+yyOmpm7p Q==; X-CSE-ConnectionGUID: R6QymcxnSwaTCy07D+OJgA== X-CSE-MsgGUID: 36Cl10ZvSn2pK0YVjuleoQ== X-IronPort-AV: E=McAfee;i="6800,10657,11790"; a="80112162" X-IronPort-AV: E=Sophos;i="6.23,242,1770624000"; d="scan'208";a="80112162" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 11:34:43 -0700 X-CSE-ConnectionGUID: T+8h8e75RFSniaeN40DCFw== X-CSE-MsgGUID: R/OXw0SeTf6ItAPvXLAW+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,242,1770624000"; d="scan'208";a="277619590" Received: from cwhite-mobl.ger.corp.intel.com (HELO localhost) ([10.245.114.180]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 11:34:42 -0700 From: Mohamed Bouhaouel To: gdb-patches@sourceware.org Cc: mohamed.bouhaouel@intel.com, stephan.rohr@intel.com, markus.t.metzger@intel.com Subject: [PATCH 05/11] gdb, remote: fix crash when accessing removed events Date: Mon, 18 May 2026 20:33:01 +0200 Message-ID: <20260518183316.127043-6-mohamed.bouhaouel@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518183316.127043-1-mohamed.bouhaouel@intel.com> References: <20260518183316.127043-1-mohamed.bouhaouel@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org From: "Bouhaouel, Mohamed" Dereferencing events after calling std::remove_if causes GDB to crash due to accessing invalidated iterators. Fix by logging events in std::remove_if. --- gdb/remote.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index a73362a26ee..94ea4466c17 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -8314,17 +8314,20 @@ remote_target::discard_pending_stop_replies (struct inferior *inf) /* Discard the stop replies we have already pulled with vStopped. */ - auto iter = std::remove_if (rs->stop_reply_queue.begin (), - rs->stop_reply_queue.end (), - [=] (const stop_reply_up &event) - { - return event->ptid.pid () == inf->pid; - }); - for (auto it = iter; it != rs->stop_reply_queue.end (); ++it) - remote_debug_printf - ("discarding queued stop reply: ptid: %s, ws: %s\n", - (*it)->ptid.to_string().c_str(), - (*it)->ws.to_string ().c_str ()); + auto iter + = std::remove_if (rs->stop_reply_queue.begin (), + rs->stop_reply_queue.end (), + [=] (const stop_reply_up &event) + { + if (event->ptid.pid () != inf->pid) + return false; + + remote_debug_printf + ("discarding queued stop reply: ptid: %s, ws: %s\n", + event->ptid.to_string ().c_str (), + event->ws.to_string ().c_str ()); + return true; + }); rs->stop_reply_queue.erase (iter, rs->stop_reply_queue.end ()); }