[v2,07/37] GDB: testsuite: riscv: Don't return value from top-level (sed)

Message ID 20260429230432.60487-8-thiago.bauermann@linaro.org
State New
Headers
Series GDB: testsuite: Fix top-level returns |

Commit Message

Thiago Jung Bauermann April 29, 2026, 11:03 p.m. UTC
  This patch is purely the result of running:

$ sed -i 's/^    return -1/    return/' riscv*.exp*

and

$ sed -i 's/^    return 0/    return/' riscv*.exp*

inside gdb/testsuite/gdb.arch.
---
 gdb/testsuite/gdb.arch/riscv-bp-infcall.exp               | 2 +-
 gdb/testsuite/gdb.arch/riscv-info-fcsr.exp                | 2 +-
 gdb/testsuite/gdb.arch/riscv-reg-aliases.exp              | 2 +-
 gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp               | 8 ++++----
 .../gdb.arch/riscv64-unwind-prologue-with-c_li.exp        | 4 ++--
 .../gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp       | 4 ++--
 .../gdb.arch/riscv64-unwind-prologue-with-mv.exp          | 4 ++--
 7 files changed, 13 insertions(+), 13 deletions(-)
  

Patch

diff --git a/gdb/testsuite/gdb.arch/riscv-bp-infcall.exp b/gdb/testsuite/gdb.arch/riscv-bp-infcall.exp
index adb937e9fea4..7d5e27debda6 100644
--- a/gdb/testsuite/gdb.arch/riscv-bp-infcall.exp
+++ b/gdb/testsuite/gdb.arch/riscv-bp-infcall.exp
@@ -19,11 +19,11 @@ 
 require {istarget "riscv*-*-*"}
 
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
    return 0
 }
diff --git a/gdb/testsuite/gdb.arch/riscv-info-fcsr.exp b/gdb/testsuite/gdb.arch/riscv-info-fcsr.exp
index 5d252beca305..930f1b24c4e7 100644
--- a/gdb/testsuite/gdb.arch/riscv-info-fcsr.exp
+++ b/gdb/testsuite/gdb.arch/riscv-info-fcsr.exp
@@ -19,11 +19,11 @@ 
 require {istarget "riscv*-*-*"} allow_float_test
 
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
    return 0
 }
diff --git a/gdb/testsuite/gdb.arch/riscv-reg-aliases.exp b/gdb/testsuite/gdb.arch/riscv-reg-aliases.exp
index eb1caf879224..998f4f485d37 100644
--- a/gdb/testsuite/gdb.arch/riscv-reg-aliases.exp
+++ b/gdb/testsuite/gdb.arch/riscv-reg-aliases.exp
@@ -16,11 +16,11 @@ 
 require {istarget "riscv*-*-*"}
 
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
    return 0
 }
diff --git a/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp b/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp
index 707777cb0df1..10415fccd040 100644
--- a/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp
+++ b/gdb/testsuite/gdb.arch/riscv-tdesc-regs.exp
@@ -22,15 +22,15 @@  require {istarget "riscv*-*-*"}
 standard_testfile
 
 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
 	  {debug quiet}] } {
     unsupported "failed to compile"
-    return -1
+    return
 }
 
 if { ![runto_main] } {
-    return -1
+    return
 }
 
 # First, figure out if we are 32-bit or 64-bit.
 set xlen [get_valueof "/d" "sizeof (\$a0)" 0]
 set flen [get_valueof "/d" "sizeof (\$fa0)" 0]
@@ -38,20 +38,20 @@  set flen [get_valueof "/d" "sizeof (\$fa0)" 0]
 gdb_assert { $xlen != 0 && $flen != 0 } "read xlen and flen"
 
 # We only handle 32-bit or 64-bit x-registers.
 if { $xlen != 4 && $xlen != 8 } {
     unsupported "unknown x-register size"
-    return -1
+    return
 }
 
 # If FLEN is 1 then the target doesn't have floating point support
 # (the register $fa0 was not recognised).  Otherwise, we can only
 # proceed if FLEN equals XLEN, otherwise we'd need more test XML
 # files.
 if { $flen != 1 && $flen != $xlen } {
     unsupport "unknown xlen/flen combination"
-    return -1
+    return
 }
 
 if { $xlen == 4 } {
     set xml_tdesc "riscv-tdesc-regs-32.xml"
 } else {
diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-c_li.exp b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-c_li.exp
index c175f0934b3c..495a720ba7c8 100644
--- a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-c_li.exp
+++ b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-c_li.exp
@@ -21,15 +21,15 @@  require {istarget "riscv64-*-*"}
 
 standard_testfile .c -foo.s
 
 if {[prepare_for_testing "failed to prepare" $testfile \
 			 "$srcfile $srcfile2"  nodebug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
-    return 0
+    return
 }
 
 gdb_breakpoint "bar"
 gdb_continue_to_breakpoint "bar"
 gdb_test "bt" \
diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
index dff317bd6155..b665dd4f4047 100644
--- a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
+++ b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-ld-lw.exp
@@ -20,15 +20,15 @@  require {istarget "riscv64-*-*"}
 
 standard_testfile riscv64-unwind-prologue-with-ld-lw.c \
 		  riscv64-unwind-prologue-with-ld-lw-foo.s
 if {[prepare_for_testing "failed to prepare" $testfile \
 			 "$srcfile $srcfile2"  nodebug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
-    return 0
+    return
 }
 
 gdb_breakpoint "bar"
 gdb_continue_to_breakpoint "bar"
 gdb_test "bt" \
diff --git a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-mv.exp b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-mv.exp
index 2afe1723a6e2..e0f66ac7f9e1 100644
--- a/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-mv.exp
+++ b/gdb/testsuite/gdb.arch/riscv64-unwind-prologue-with-mv.exp
@@ -19,16 +19,16 @@ 
 require {istarget "riscv64-*-*"}
 
 standard_testfile .c .s
 if {[prepare_for_testing "failed to prepare" $testfile \
 			 "$srcfile $srcfile2"  nodebug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
     fail "can't run to main"
-    return 0
+    return
 }
 
 gdb_breakpoint "bar"
 gdb_continue_to_breakpoint "bar"
 gdb_test "bt" \