[v2,37/37] GDB: testsuite: XML: Don't return -1 nor 0 from top-level

Message ID 20260429230432.60487-38-thiago.bauermann@linaro.org
State New
Headers
Series GDB: testsuite: Fix top-level returns |

Commit Message

Thiago Jung Bauermann April 29, 2026, 11:04 p.m. UTC
  This patch changes statements that return -1 or 0 from the top level.
---
 gdb/testsuite/gdb.xml/tdesc-arch.exp   | 4 ++--
 gdb/testsuite/gdb.xml/tdesc-regs.exp   | 2 +-
 gdb/testsuite/gdb.xml/tdesc-reload.exp | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)
  

Patch

diff --git a/gdb/testsuite/gdb.xml/tdesc-arch.exp b/gdb/testsuite/gdb.xml/tdesc-arch.exp
index f3bb9ba26523..1f9b3c200571 100644
--- a/gdb/testsuite/gdb.xml/tdesc-arch.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-arch.exp
@@ -29,11 +29,11 @@  gdb_test_multiple "set architecture" $msg {
 	pass $msg
     }
     -re "Requires an argument. Valid arguments are (\[^ \]*), auto\\.\r\n$gdb_prompt $" {
 	# If there is just one supported architecture, we can't do this test.
 	unsupported "tdesc-arch.exp"
-	return -1
+	return
     }
 }
 
 set default_arch ""
 set msg "read default architecture"
@@ -45,11 +45,11 @@  gdb_test_multiple "show architecture" $msg {
 }
 
 # If that did not work, no point running further tests.
 if { "$arch1" == "" || "$arch2" == "" || "$default_arch" == "" } {
     unresolved "architecture XML tests"
-    return -1
+    return
 }
 
 # Run these tests twice, once for $arch1 and once for $arch2, to
 # make sure that the tdesc file overrides the global default.
 # TRANS_MODE indicates how newlines should be represented; it should
diff --git a/gdb/testsuite/gdb.xml/tdesc-regs.exp b/gdb/testsuite/gdb.xml/tdesc-regs.exp
index 96f0fe089aa5..092355020b2c 100644
--- a/gdb/testsuite/gdb.xml/tdesc-regs.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-regs.exp
@@ -107,11 +107,11 @@  if {[string equal ${core-regs} ""]} {
     } elseif { $feature_test_unsupported } {
 	# Remind maintainers to add test support.
 	unsupported "register tests (missing architecture-specific core-regs setting)"
     }
 
-    return 0
+    return
 }
 
 # Otherwise, we support both XML and target defined registers.
 
 # Make sure we reject a description missing standard registers,
diff --git a/gdb/testsuite/gdb.xml/tdesc-reload.exp b/gdb/testsuite/gdb.xml/tdesc-reload.exp
index cdd075de099d..41dc30a7a5a1 100644
--- a/gdb/testsuite/gdb.xml/tdesc-reload.exp
+++ b/gdb/testsuite/gdb.xml/tdesc-reload.exp
@@ -19,15 +19,15 @@ 
 require allow_xml_test
 
 standard_testfile
 
 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-    return -1
+    return
 }
 
 if {![runto_main]} {
-    return 0
+    return
 }
 
 # Three files we're going to write out to.
 set xml_file_1 [host_standard_output_file outfile1.xml]
 set xml_file_2 [host_standard_output_file outfile2.xml]
@@ -58,11 +58,11 @@  gdb_test_no_output "set tdesc filename $xml_file_1" \
 # Load the executable.
 gdb_load ${binfile}
 
 # Run to `main' where we begin our tests.
 if {![runto_main]} {
-    return -1
+    return
 }
 
 # Run info registers just to check this appears to run fine with the
 # new target description.
 gdb_test -lbl "info all-registers" "" "Run info registers"