From patchwork Wed Dec 31 23:18:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 127284 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A3C5F4BA2E26 for ; Wed, 31 Dec 2025 23:19:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3C5F4BA2E26 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=PgjIAnU6 X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id E426B4BA2E07 for ; Wed, 31 Dec 2025 23:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E426B4BA2E07 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E426B4BA2E07 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767223097; cv=none; b=LlQWrjpeOkhRty6/wKm0py5LOhU2jH8+PKLTpQlxA81tigDPWQyewYxG6MTBHlSykM53/9O3E5Ji/nRtLifvgdkEvJBPDkbv3RHnCft+sMkh7LAjAvvsHa9l/T5nENjAz86Z+Yr7SR8wKX7IEZd4S4ftnqClZNaLe6N8GDaMDBo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767223097; c=relaxed/simple; bh=R0lSDutwpAe4GAg5BGZeHL56hIXVy9/9qpy6JF3hQkg=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=uP+oWuLQy4CgXXh73Oj+cV9zbP04c/IKCzrWZcjHTmi8I4nNJ9a+N9SQNKwfyBkfRRKZNzsud96D3EAFCcaCNKZG6VfU+ZaPTDNabhdJb/su3bvNSC2xauo81kZzGMTgqNFWidSxARkpb8Jis2Y6lqKNkb6gqYi5BdqQPhAiEVc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E426B4BA2E07 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id b4Kov1G3gVCBNb5SKvXRbO; Wed, 31 Dec 2025 23:18:16 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id b5SJvlxJLcu11b5SJvppzv; Wed, 31 Dec 2025 23:18:15 +0000 X-Authority-Analysis: v=2.4 cv=bKYWIO+Z c=1 sm=1 tr=0 ts=6955af37 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=CCpqsmhAAAAA:8 a=rTyjRlD9Jm3cdqAwY1IA:9 a=QEXdDO2ut3YA:10 a=ul9cdbp4aOFLsgKbc677:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ApFlxUmi8z7XZIM+Khkg70FphTLyKeAAuX+TNidiisg=; b=PgjIAnU64+ENVDFS8Nb1RuEdhS jK+IXB7VbKyuueatvNVQjgc/T+aEfCs69/9OesNXNm3EwchBGzs8lM+OoqwVDQM42gx/DBpeCF+W4 UaPimL1xIxEY1T+pxAUCph577; Received: from 75-166-246-134.hlrn.qwest.net ([75.166.246.134]:51708 helo=[192.168.122.1]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vb5SJ-00000000CDk-1A5n; Wed, 31 Dec 2025 16:18:15 -0700 From: Tom Tromey Date: Wed, 31 Dec 2025 16:18:13 -0700 Subject: [PATCH 3/3] Have TUI react to disassembly parameter changes MIME-Version: 1.0 Message-Id: <20251231-param-set-observ-v1-3-c6a63695f54d@tromey.com> References: <20251231-param-set-observ-v1-0-c6a63695f54d@tromey.com> In-Reply-To: <20251231-param-set-observ-v1-0-c6a63695f54d@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.246.134 X-Source-L: No X-Exim-ID: 1vb5SJ-00000000CDk-1A5n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-246-134.hlrn.qwest.net ([192.168.122.1]) [75.166.246.134]:51708 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCr+fm6Wp04q1kUbXrkHgGdvbGVe/ExmLuP2cwlAos+L4PewjT4Cw89lMUIyM1W/J1rJQ6E4nzIpFhUFQW+1hseaO4vBc74W12OznuiCfyEQjsoJsp8b wdpsIiBZokU5hKLYvYWGGscsLEhDARf/LowsNVxEHfgxEpzSgnavHOiBTgsMSm5jpwp500PzYp5PkGwNUbMr+a9U+i9JOkIg0Jo= X-Spam-Status: No, score=-3014.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_LOTSOFHASH, KAM_SHORT, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org With this patch, changes to "print symbol-filename", "filename-display", or "print max-symbolic-offset" will now cause the TUI disassembly window to update. tui_source_window_base::style_changed is renamed to reflect its use as a way to force a refresh. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33249 --- gdb/testsuite/gdb.tui/tui-disasm-styling.exp | 23 +++++++++++++++++++++++ gdb/tui/tui-disasm.c | 23 +++++++++++++++++++++++ gdb/tui/tui-disasm.h | 10 +++++++++- gdb/tui/tui-source.c | 2 +- gdb/tui/tui-winsource.c | 4 ++-- gdb/tui/tui-winsource.h | 5 +++-- 6 files changed, 61 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.tui/tui-disasm-styling.exp b/gdb/testsuite/gdb.tui/tui-disasm-styling.exp index 685974411dfbba1d83104056812447585ee6a41f..311e7af876324cc38d61947fba39c61482098777 100644 --- a/gdb/testsuite/gdb.tui/tui-disasm-styling.exp +++ b/gdb/testsuite/gdb.tui/tui-disasm-styling.exp @@ -66,3 +66,26 @@ check_asm_output true "asm output is styled once again" Term::command "set style sources off" check_asm_output true "asm output is styled when source styling is off" + +Term::command "set print max-symbolic-offset 1" +set asm_output [Term::get_region 1 1 78 13 "\n"] +# Look for a line that has a hex offset and some assembly, but that +# does not have . We can't really check for the assembly +# directly so we just look for any letter. +gdb_assert {[regexp -- "$hex\[^<\]* \[a-z\]" $asm_output]} \ + "reacted to change to max-symbolic-offset" + +# These next tests are a bit simpler to write without styling. +Term::command "set style enabled off" +Term::command "set filename-display absolute" +Term::command "set print symbol-filename on" +set asm_output [Term::get_region 1 1 78 13 "\n"] +# We can't assume the final part of the filename will be visible, so +# just look for any directory separator. +gdb_assert {[regexp -- "