diff mbox series

[1/5] gdb: Update comment of c_type_print_template_args.

Message ID 20251229151518.475440-2-christina.schimpe@intel.com
State New
Headers
Series Template type parameter resolution |

Commit Message

Christina Schimpe Dec. 29, 2025, 3:15 p.m. UTC 
  Remove function description for TABLE.  This function does not take a
parameter "table".
---
 gdb/c-typeprint.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Comments

Tom Tromey Jan. 6, 2026, 7:05 p.m. UTC | #1 
>>>>> "Christina" == Christina Schimpe <christina.schimpe@intel.com> writes:

Christina> Remove function description for TABLE.  This function does not take a
Christina> parameter "table".

Thanks, this is ok, even obvious.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Christina Schimpe Jan. 13, 2026, 9:09 a.m. UTC | #2 
Hi Tom,

Thank you for the quick feedback. I've pushed this.

Christina

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 6. Januar 2026 20:05
> To: Schimpe, Christina <christina.schimpe@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/5] gdb: Update comment of
> c_type_print_template_args.
> 
> >>>>> "Christina" == Christina Schimpe <christina.schimpe@intel.com>
> writes:
> 
> Christina> Remove function description for TABLE.  This function does
> Christina> not take a parameter "table".
> 
> Thanks, this is ok, even obvious.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928
diff mbox series

Patch

diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c
index 2f921aec8fc..7b1fa7f5c7c 100644
--- a/gdb/c-typeprint.c
+++ b/gdb/c-typeprint.c
@@ -787,14 +787,8 @@  c_type_print_varspec_suffix (struct type *type,
     }
 }
 
-/* A helper for c_type_print_base that displays template
-   parameters and their bindings, if needed.
-
-   TABLE is the local bindings table to use.  If NULL, no printing is
-   done.  Note that, at this point, TABLE won't have any useful
-   information in it -- but it is also used as a flag to
-   print_name_maybe_canonical to activate searching the global typedef
-   table.
+/* A helper for c_type_print_base_struct_union that displays template
+   parameters.
 
    TYPE is the type whose template arguments are being displayed.