diff mbox series

[v4,2/6] gdb, cli: remove left-over code from "set_logging_on".

Message ID 20251213143709.301799-3-christina.schimpe@intel.com
State New
Headers
Series Refinement of scheduler-locking settings |

Commit Message

Christina Schimpe Dec. 13, 2025, 2:37 p.m. UTC 
  From: Natalia Saiapova <natalia.saiapova@intel.com>

This is a refactoring.  Remove the left-over code, which rewrites
the logging filename in "set logging on" command.

The code became unused after the deprecation of "set logging (on|off)"
command.  Before the deprecation, the command could also take a file
name and rewrite the logging file, e.g.:
  (gdb) set logging on lalala
  Copying output to lalala.
  Copying debug output to lalala.

After the command was deprecated and reimplemented as an alias to "set
logging enable on", additional input after "on" became invalid:

  (gdb) set logging on lalala
  Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated.
  Use 'set logging enabled on'.

  "on" or "off" expected.
  (gdb) set logging on lalala
  "on" or "off" expected.
  (gdb) set logging enable on lalala
  "on" or "off" expected.
  (gdb) set logging enable on
  Copying output to gdb.txt.
  Copying debug output to gdb.txt.

Approved-By: Tom Tromey <tom@tromey.com>
---
 gdb/cli/cli-logging.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
index 9727b5a3538..97e45765022 100644
--- a/gdb/cli/cli-logging.c
+++ b/gdb/cli/cli-logging.c
@@ -159,11 +159,6 @@  handle_redirections (int from_tty)
 static void
 set_logging_on (const char *args, int from_tty)
 {
-  const char *rest = args;
-
-  if (rest && *rest)
-    logging_filename = rest;
-
   handle_redirections (from_tty);
 }