diff mbox series

[Pushed,as,obvious] gdbserver: regcache: Update comment in supply_regblock

Message ID 20250405234756.812978-1-thiago.bauermann@linaro.org
State New
Headers
Series [Pushed,as,obvious] gdbserver: regcache: Update comment in supply_regblock |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Thiago Jung Bauermann April 5, 2025, 11:47 p.m. UTC 
  Since commit 84da4a1ea0ae ("gdbserver: refactor the definition and uses of
supply_regblock") there is no case where supply_regblock is passed a
nullptr for the BUF argument, and there is even a gdb_assert to make
sure of it.

Therefore remove that part of the documentation comment.
---
 gdbserver/regcache.cc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


base-commit: c2f55040d34784a5c40d25f6a58615da1b4a52be

Comments

Aktemur, Tankut Baris April 7, 2025, 6:16 p.m. UTC | #1 
On Sunday, April 6, 2025 1:48 AM, Thiago Jung Bauermann wrote:
> Since commit 84da4a1ea0ae ("gdbserver: refactor the definition and uses of
> supply_regblock") there is no case where supply_regblock is passed a
> nullptr for the BUF argument, and there is even a gdb_assert to make
> sure of it.
> 
> Therefore remove that part of the documentation comment.

Thanks for fixing this.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
index c08c9ae06c14..96855f03c3e5 100644
--- a/gdbserver/regcache.cc
+++ b/gdbserver/regcache.cc
@@ -353,8 +353,7 @@  supply_register_by_name_zeroed (struct regcache *regcache,
 #endif
 
 /* Supply the whole register set whose contents are stored in BUF, to
-   REGCACHE.  If BUF is NULL, all the registers' values are recorded
-   as unavailable.  */
+   REGCACHE.  */
 
 void
 supply_regblock (struct regcache *regcache, const void *buf)