[1/1] riscv: Add missing disassembler option `max`

Message ID 20250324152910.155115-1-m.pikula@partner.samsung.com
State New
Headers
Series [1/1] riscv: Add missing disassembler option `max` |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Test passed

Commit Message

Marek Pikula March 24, 2025, 3:29 p.m. UTC
  The flag already exists but it's not been exposed to user.

Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com>
---
 opcodes/riscv-dis.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Tom Tromey March 25, 2025, 1:38 p.m. UTC | #1
>>>>> "Marek" == Marek Pikuła <m.pikula@partner.samsung.com> writes:

Thanks for the patch.

Marek> The flag already exists but it's not been exposed to user.

opcodes patches should probably go to the binutils list.

thanks,
Tom
  
Marek Pikula March 25, 2025, 1:49 p.m. UTC | #2
Hi, thanks for the reminder. Resubmitted here: 
https://sourceware.org/pipermail/binutils/2025-March/140176.html

Best, Marek

On 25.03.2025 14:38, Tom Tromey wrote:
> Thanks for the patch.
>
> Marek> The flag already exists but it's not been exposed to user.
>
> opcodes patches should probably go to the binutils list.
>
> thanks,
> Tom
>
  

Patch

diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
index c341a0fe317..a8a89311ebf 100644
--- a/opcodes/riscv-dis.c
+++ b/opcodes/riscv-dis.c
@@ -66,7 +66,7 @@  struct riscv_private_data
   const char (*riscv_fpr_names)[NRC];
   /* If set, disassemble as most general instruction.  */
   bool no_aliases;
-  /* If set, disassemble without checking architectire string, just like what
+  /* If set, disassemble without checking architecture string, just like what
      we did at the beginning.  */
   bool all_ext;
 };
@@ -1577,6 +1577,9 @@  static struct
   riscv_option_arg_t arg;
 } riscv_options[] =
 {
+  { "max",
+    N_("Disassemble without checking architecture string."),
+    RISCV_OPTION_ARG_NONE },
   { "numeric",
     N_("Print numeric register names, rather than ABI names."),
     RISCV_OPTION_ARG_NONE },