| Message ID | 20250320-attribute-madness-v1-4-79d42789f881@adacore.com |
|---|---|
| State | New |
| Headers |
Return-Path: <gdb-patches-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A0303857B84 for <patchwork@sourceware.org>; Thu, 20 Mar 2025 19:30:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A0303857B84 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=SecnL+yx X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 3FF1A3858031 for <gdb-patches@sourceware.org>; Thu, 20 Mar 2025 19:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FF1A3858031 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FF1A3858031 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742498825; cv=none; b=UWYzEWSLNF55pUmHzX8Jy3cthnrZKIUQEX2zdvpOoRVwKZtUayba8bAkRPXmDFnyrnvVuK0bD+p65/zaMMrRZopBBNA7KUTZstTPO3ySsNOiaHWSq3VaXmwPcPyc+nCnjRP+OGHRcHgHmgys7zh9OdVpw5s0Ta6FCPsZXrpORvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742498825; c=relaxed/simple; bh=vBWKKRn/A5dARw79lGLO3lrarSFIR70aeHv6BhXp+v0=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=C3HCpd2IUQZ+1kuZ8IW9gBM7Ihr/G9/UW2dpDn7NWCY+Y0gzDi0tcpvUMf39Swyaa17cUdy1eDdycXQ+48wzaVQEaibEgi7QCwqpDtBietcXOwFM+5R+YHwfMT/IRhFM7SZKu486IPz6v4inzF+yDKYQP58RYY3UrpqcEM3yjso= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FF1A3858031 Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-85b3f92c8f8so105799839f.1 for <gdb-patches@sourceware.org>; Thu, 20 Mar 2025 12:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1742498824; x=1743103624; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=th3QOmh9+s6/eh0QzEUvfEMBBrpXlSNoPZMYV++mo+o=; b=SecnL+yxecpiMw4InF/TuufNuzSy+XErQA0AHw2/reUFRWrXpISFumcqgzzlOAzCjj Q1d0XqcEZXSDNQnhDePept4p3h/55z1F+3y3ocmA3ImzZ0oOvLudvYEbnd/CzuFgkATP ZWiB3SXYhWNlpB7f+u07fP+tZHgCpYywfYIuAoekObgo6feax+6ZCIscYH/hGD7z9sZ6 sTWFiY00JgSya4nMZeSwwPHMJGP5DZzHDt7VmdiAql7RTnvigvaf85uyzecy321VCLJF JHSrkRMOdibbiAOlh+B6YcpKxdlu4UfEZLGl06VP8ihLVtiBSZn+Na5G/N2+A9pxc9ZW 16wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742498824; x=1743103624; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=th3QOmh9+s6/eh0QzEUvfEMBBrpXlSNoPZMYV++mo+o=; b=Cb9iK6NO8MNG5+bZik0HOl6WjDX4hEbabCS4Hr/+hngc8IU98KHUTy5/JMj0lGQC+x YXi5+y2DrZc3qh9aYMXeMCvEL6ZrXjiwNnEuBgEXLAzm/LW2FEjgS8igQl6Vu28P0VmY Q2L93skTDdGXna3q0bz3vjXJAbGrmTTopSvcOHPZkPum5kcHDbSMiZsb1fTif5AQlY6w Wg2MCx5klMRbf94A46baj8XzYJ0TxNMN815XBCNBqQIlY86LSg+HXrUf51OFDion0uqG yurlI7aqin3GNynPiFqn/DeyKdWQxNHlI2ivvriq/JILQrhSDOBW1gzqx2oaqM+ZqqeU 0EGw== X-Gm-Message-State: AOJu0YwCZ+MEyRKy7RDonYL5AdkFRKHejXdhPHYDfiUsT26in5rSajEf BwNx8jVBKoAa32NDnWamXgET+Kxv0YQ/X+4MuUQrrj8pS2hKGMMbuPyRE1XNI9WfOKggowuktHQ = X-Gm-Gg: ASbGncsqsVW5IBLJ+bR3Sc/RmJU9NSGYkJeFTvOP0BxDXxuE46ZX7FTLhNZd338DhD0 tX6G5mZtjmQvk+igTm3Fk7DW8C5beZIm5qRXaFB8b1tdOUR1az+WGsWKqaAYG9MDzoYtZvnU//r fS0CVpC6NZwgQ12/t7X/E9RM5FSgxDD3EFvIzOi66CITE1UXIaiwS8acWupQn5USMbvKUqInwYc OgioK9AImRaMfXQLGNN/2RCaiox3KrtgeH6NhUaujkZsk7jEAMJgYeiH421Qyu+cmkj4I7KLDdB zrjmbUot52o7a6K4JG08b1SuffN0wYplOzD5ATwn7jZdysk2vztytGmtxQh2zX7OMTb1ILX76B0 pln8IL4Rt X-Google-Smtp-Source: AGHT+IFAP+zFOM3oZ5Pi9DTh7/+JIIHOyAHJWJqD0V5HraKzXH9RycX0fOtb3ed7Ci4tBJJ/wPAMOQ== X-Received: by 2002:a05:6602:b8b:b0:85b:505a:7def with SMTP id ca18e2360f4ac-85e2ca729dfmr71416139f.6.1742498824369; Thu, 20 Mar 2025 12:27:04 -0700 (PDT) Received: from localhost.localdomain (97-122-123-18.hlrn.qwest.net. [97.122.123.18]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-85e2bc6ab31sm8285939f.22.2025.03.20.12.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 12:27:04 -0700 (PDT) From: Tom Tromey <tromey@adacore.com> Date: Thu, 20 Mar 2025 13:27:00 -0600 Subject: [PATCH 04/13] Use attribute::unsigned_constant for DW_AT_bit_stride MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250320-attribute-madness-v1-4-79d42789f881@adacore.com> References: <20250320-attribute-madness-v1-0-79d42789f881@adacore.com> In-Reply-To: <20250320-attribute-madness-v1-0-79d42789f881@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tromey@adacore.com> X-Mailer: b4 0.14.2 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org |
| Series |
More work on DW_FORM_* and sign handling
|
|
Checks
| Context | Check | Description |
|---|---|---|
| linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 | fail | Patch failed to apply |
| linaro-tcwg-bot/tcwg_gdb_build--master-arm | fail | Patch failed to apply |
Commit Message
Tom Tromey
March 20, 2025, 7:27 p.m. UTC
DW_AT_bit_stride uses an unsigned constant, so make this explicit in the reader. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32680 --- gdb/dwarf2/read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 81f4ba98608528413e6463c3b04ddc3796c8e23c..b48e5db82bca388fb122de05695ea1f3c9abdb1a 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -12176,7 +12176,7 @@ read_array_type (struct die_info *die, struct dwarf2_cu *cu) attr = dwarf2_attr (die, DW_AT_bit_stride, cu); if (attr != NULL) - bit_stride = attr->constant_value (0); + bit_stride = attr->unsigned_constant ().value_or (0); /* Irix 6.2 native cc creates array types without children for arrays with unspecified length. */