From patchwork Thu Mar 20 19:27:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 108653 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F7743857C5F for ; Thu, 20 Mar 2025 19:35:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F7743857C5F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=TSqj2Pzz X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 428813857C6E for ; Thu, 20 Mar 2025 19:27:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 428813857C6E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 428813857C6E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742498832; cv=none; b=Teu1TiA2XCXUAEn0qc7CHY9d3CeuUtHLS67RV9582JdoxslxAROZVTdIbQZ+4tBuE24383PmX5RZTZDeftCfY9gog4SweIqqt6Q2gn+bKV2yIdgK01N2lGinU2vAeDo5hN/h+S3r2ID0Glj0OWh8ukdqjSLAO9uvVYZ8+TlDRgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742498832; c=relaxed/simple; bh=FFU//LYsIVCBkUphx3kNSON5vJJouqbsi1A/xOJpHqs=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=GLADQaU+6URWDJHfGTAVUTUcatpudgyZPxXCbpBArZhYefervfA6xKlCSLAPcAF1hcu8W5e0TFX8IbFNwys81aXyZh6R/m7u5Z0sgPvUahgAjSVmqJYSEIXbhy4Dnz7c9AZzrDApE9s4mTr44pGwpE3mwiPWRv8nJ024WK+P7m8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 428813857C6E Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-85b4170f1f5so32635939f.3 for ; Thu, 20 Mar 2025 12:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1742498831; x=1743103631; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oTq9ixHvT3heZ5gzuoqb8aRtWPUipK9iKRN1Wkbuptw=; b=TSqj2PzzdBLH7T+I5VN3HvfYR9SWZfx18EzRnhTEn1+mBBXpPjGnvO4uA54DGw1+gm E5rz4t2T6Nm7fEdPvlO/skSKpgDNHgcFVJHgkafsLIKKxdWFVu1+evZ+CemLHONbkaKs SElMhEXE9lXRdOpEb8kpUMq1/tPLknFQxBtkDNOZ7OwnEVONkkM3fj/H5DAf1X858hpU 80NOC+hGqMFfok6G+VWaI5QiZ0JkVsYYImyU4zIosyKPAn0v6Eyc2IKKNJbM/+pqz+7S yBgHvFl2PXq9QE9PElGzo4/ULgJkub6e6t2t2QVH4fM45Wj4S5WWXisFPsFJ+4l/rpHV 2K6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742498831; x=1743103631; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oTq9ixHvT3heZ5gzuoqb8aRtWPUipK9iKRN1Wkbuptw=; b=WoVo5aOz/WkF5YRtZylf9shCNDQihutM30+rOSNHMod4ldXWuVF86aIhO3lxvzK18D SAxkdZEhUnaBaNxAdXjtRmlv8Pbb4cVaP6hklYOM8fcfL1+l0+nORkq5Q3Q12XQaEvHV U1Cn103nlGLIKKtZ2QHMe8a9eE/mefsIcaeqm/aY/ygRIyprnEsdhimFHdlndefqHYu8 38Q78l5+pmjE1s/LL8u8KroDgiAwamdadBIvf4fnfamMBZhaJeaHodMv3vovZZEstayT +FdMpAExgjq0s9zj0n5SaSKf63N9qHTeR/ceWNXkOwT4ZH4mBNdpZhjuklzDoi9q5aDh AoJQ== X-Gm-Message-State: AOJu0Yxlv0TE2M/2KilP9+cCpuvK060JiOiAlQYaqRH2hJkPDD12Llns YV1ZMD3EtIx6eh88OqdticpO8p64iGtXVv9Gz14MCoJSjsadUC9vpAaVHHQ7CGdZbWYL9JWdGhI = X-Gm-Gg: ASbGnctepBuAAMzZzDh+86er6Tsw6EINkoaV257CAMXXruUkQ2mcwC4OWOJNNjbQBGq wLGtdYOtU5gfMVVdrafrerQXAuQIZUBIXt4dmMc4MCoFvjO88k7I1w1X6hr9vlV19PIhMxm1lsf ALkhHmFVOiGv/olYhYfSZGOC+KuVyEfoY6oQEMnSAG79keT+GTHywOAwFwoNyhm86XmIMG/2Mgi yVP792UCBko9S3JNnf8V4EM0FrX//UK7V2m6TxPZZ85IHBSGtX1qUdXOoCb9QcYyINyiF6zNyM+ /xuRlKDWdX9HVYt1NUQZfUOZMtCFFBqap9wjRbbIB9rbOW7ameOvf2eU/PPDYSnRohF7jAeiII7 xMQwNOzp0 X-Google-Smtp-Source: AGHT+IGbzVFJCahAslMjUgJhEL3sesn/lG0lYtx+9dLM8LBAs/YG365TeSpKcJqSASSULpH+AQFx1w== X-Received: by 2002:a05:6602:3896:b0:85e:1ee9:1c18 with SMTP id ca18e2360f4ac-85e2cb1dda1mr53901239f.9.1742498831452; Thu, 20 Mar 2025 12:27:11 -0700 (PDT) Received: from localhost.localdomain (97-122-123-18.hlrn.qwest.net. [97.122.123.18]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-85e2bc6ab31sm8285939f.22.2025.03.20.12.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 12:27:10 -0700 (PDT) From: Tom Tromey Date: Thu, 20 Mar 2025 13:27:06 -0600 Subject: [PATCH 10/13] Use attribute::signed_constant in attribute::as_boolean MIME-Version: 1.0 Message-Id: <20250320-attribute-madness-v1-10-79d42789f881@adacore.com> References: <20250320-attribute-madness-v1-0-79d42789f881@adacore.com> In-Reply-To: <20250320-attribute-madness-v1-0-79d42789f881@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org This changes attribute::as_boolean to use attribute::signed_constant. This is maybe overkill but lets any reasonable constant form through. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32680 --- gdb/dwarf2/attribute.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/attribute.c b/gdb/dwarf2/attribute.c index 25cf2b62cfd1c8f4981be2787fe4ade8c8c66b81..d3b3eed81bd500bf06dc8c83cab7ae1fa8c17974 100644 --- a/gdb/dwarf2/attribute.c +++ b/gdb/dwarf2/attribute.c @@ -323,5 +323,8 @@ attribute::as_boolean () const return true; else if (form == DW_FORM_flag) return u.unsnd != 0; - return constant_value (0) != 0; + /* Using signed_constant here will work even for the weird case + where a negative value is provided. Probably doesn't matter but + also seems harmless. */ + return signed_constant ().value_or (0) != 0; }