From patchwork Tue Mar 11 14:12:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 107681 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36FFF3857BA7 for ; Tue, 11 Mar 2025 14:19:05 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 2A1833857C6D for ; Tue, 11 Mar 2025 14:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A1833857C6D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A1833857C6D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741702403; cv=none; b=BpDDU1V5WCaxX2f2pQfj95GT0fhTdSdwIN1VUfT1zuONbMhM4r2YaLGefa7YyIxgli3+L5wAUGduefV22A+E0cspLGU+ZKRhnfladn7iMEW5aCE5shNRlIdIyFyH2j/QZgoA3oaTB++umBNX7dQxQGc5YBFwy10IZOvTSXBfpXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741702403; c=relaxed/simple; bh=AN96AxwbjLDFu3AiVGreXeuAfMUTiBFghr0iBOItF5Q=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=cnU2BEN/GX7PIRuT/xGKdSsdXw5MA8wpmTETL6LfZcU9wzjKowyiVIpC4rpTX1p4XEwytBrggsvC4KX8pstnknjRFdIRnFJrAFHJrwMYpt74evnRJdROlfF22YG8qOc7X+6EvMXw+Dkff7oT+Cs7Ry/zxaB1CqL2K6uqG3Xb7+I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id roJotpR2ZzZPas0LktGGPb; Tue, 11 Mar 2025 14:12:52 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id s0Ljts4gURoGBs0LktEEi4; Tue, 11 Mar 2025 14:12:52 +0000 X-Authority-Analysis: v=2.4 cv=C/bvyxP+ c=1 sm=1 tr=0 ts=67d044e4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=BDyQ4xKupJWBFD7bsUgA:9 a=QEXdDO2ut3YA:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eXgb/KXKQkKcc0xG3kk1DD2mk/dDOMbblG8XW3QquBg=; b=SHEEkp5qJXva9q8Ssm5g6gtnJA fSDlI2IxB2yS0MnmVFY2Hd5cUmo/aNfGZr0aiyaMcwtaBr37FBQjtVpZKszHW99Gpb9W5eC5oHUS8 itbG8RkPBRA6zYJIF78p13KnX; Received: from 97-118-51-80.hlrn.qwest.net ([97.118.51.80]:33770 helo=prentzel.local) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1ts0Lj-000000003jP-2843; Tue, 11 Mar 2025 08:12:51 -0600 From: Tom Tromey Date: Tue, 11 Mar 2025 08:12:53 -0600 Subject: [PATCH 17/28] Remove expand_symtabs_matching MIME-Version: 1.0 Message-Id: <20250311-search-in-psyms-v1-17-d73d9be20983@tromey.com> References: <20250311-search-in-psyms-v1-0-d73d9be20983@tromey.com> In-Reply-To: <20250311-search-in-psyms-v1-0-d73d9be20983@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.51.80 X-Source-L: No X-Exim-ID: 1ts0Lj-000000003jP-2843 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-51-80.hlrn.qwest.net (prentzel.local) [97.118.51.80]:33770 X-Source-Auth: tom+tromey.com X-Email-Count: 18 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCyqdXWjs9NSIIjy18JS0gBr+K5+FkeAxn0tfJ9Qp59BtsBlo/C7JX35q67S+iFtqhvMhqrV+/CXZkhUW9rFLj7C+/NkgOmTA6gt50pH0gueOzn4YQiV RYSOtB1H/yAp6ZwSfh1FfGEybbl9bk2QhMxHMCbFayMua2JYQPPZxNiUDmUs6Di2XFd1hE0tNltW/mwBCDoqdTJA6qvj+o7U5XY= X-Spam-Status: No, score=-3016.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_BL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The last caller of the global expand_symtabs_matching function has been changed, so now we can remove this function. --- gdb/symfile.c | 25 ------------------------- gdb/symfile.h | 9 --------- 2 files changed, 34 deletions(-) diff --git a/gdb/symfile.c b/gdb/symfile.c index b0c178a5aeb75c23862d6dd25a9e4bc6235ee231..8e229719b39f6cc4081448e5ec5fa82a0ead691f 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -3756,31 +3756,6 @@ symfile_free_objfile (struct objfile *objfile) objfile->pspace ()->remove_target_sections (objfile); } -/* Wrapper around the quick_symbol_functions expand_symtabs_matching "method". - Expand all symtabs that match the specified criteria. - See quick_symbol_functions.expand_symtabs_matching for details. */ - -bool -expand_symtabs_matching (expand_symtabs_file_matcher file_matcher, - const lookup_name_info &lookup_name, - expand_symtabs_symbol_matcher symbol_matcher, - expand_symtabs_expansion_listener expansion_notify, - block_search_flags search_flags, - domain_search_flags domain, - expand_symtabs_lang_matcher lang_matcher) -{ - for (objfile *objfile : current_program_space->objfiles ()) - if (!objfile->expand_symtabs_matching (file_matcher, - &lookup_name, - symbol_matcher, - expansion_notify, - search_flags, - domain, - lang_matcher)) - return false; - return true; -} - /* Wrapper around the quick_symbol_functions map_symbol_filenames "method". Map function FUN over every file. See quick_symbol_functions.map_symbol_filenames for details. */ diff --git a/gdb/symfile.h b/gdb/symfile.h index c2e5142c045dab72fad9d73abd259813f9caef1e..e72030f5f0e1e5e0b094d288e4a81c58264222b8 100644 --- a/gdb/symfile.h +++ b/gdb/symfile.h @@ -345,15 +345,6 @@ symfile_segment_data_up get_symfile_segment_data (bfd *abfd); extern scoped_restore_tmpl increment_reading_symtab (void); -bool expand_symtabs_matching - (expand_symtabs_file_matcher file_matcher, - const lookup_name_info &lookup_name, - expand_symtabs_symbol_matcher symbol_matcher, - expand_symtabs_expansion_listener expansion_notify, - block_search_flags search_flags, - domain_search_flags kind, - expand_symtabs_lang_matcher lang_matcher = nullptr); - void map_symbol_filenames (symbol_filename_listener fun, bool need_fullname); /* Target-agnostic function to load the sections of an executable into memory.