From patchwork Mon Mar 10 15:10:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 107588 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4BE8F3858CDB for ; Mon, 10 Mar 2025 15:23:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4BE8F3858CDB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=jwIk4R22 X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 48F653858401 for ; Mon, 10 Mar 2025 15:20:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48F653858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48F653858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741620055; cv=none; b=dUT9NsimR6Hs8bJXnI+X6RknnnSLV584Tx0sZe3FOmEQ2Nnzq+NjPSXWHwYOTvq2rNXo1k8j4KZfngvIdrBfqti2uV2MSGdCuHpL7iW60Nx6rYZw84epFi6C5fAa7ql72WH+PJeXof3VZslvthZeaAbAAzheAZpwFMFgxFO9tC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741620055; c=relaxed/simple; bh=+/fgrxM7bAeMlKv2ZMp0tNHnhpw1VD8VqK63+lhXqcA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eMweV42htRcHi0fFlsZ9yns/3aiuCl5GIV7uKxjbOjEW7rimkdd8Hhf+2t4XEL04c1FwAPvtQ+02kUCVAcR98iTVPK8EiYPMKM8gKWzXLGF3QDKzek89tECPfmPH7y9rXdHoCZ/FhOFAEOtX51vGonFBAkksF3LvFPyfqSgyX+c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48F653858401 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 52AFKoXQ240782 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Mar 2025 11:20:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 52AFKoXQ240782 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1741620054; bh=Qgx0Li2uQ7jXCOH4VZqqxLHb1KzDQGr9uZigbHUxYnU=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=jwIk4R22yVnK2+nS7EvXmOz8gipeDBgYPdW2+vjtDbtfUOsmd3UqcT2sl+4iGmEdH HgKhHU6Sl275zXqnsCOhishL3fAD6MTNOKHBCOs4UyFh2zNU4BDPWBWZ9TYC0XoJsE YSpJNkbL1/qpqlTL8atAx0AbLmXcj/k44Gijy4Mw= Received: by simark.ca (Postfix, from userid 112) id E63CB1E0FE; Mon, 10 Mar 2025 11:12:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-Spam-Level: X-Spam-Status: No, score=-3187.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from simark.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4386A1E105; Mon, 10 Mar 2025 11:12:13 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 2/4] gdb: clear internalvar on destruction Date: Mon, 10 Mar 2025 11:10:47 -0400 Message-ID: <20250310151211.2708331-3-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250310151211.2708331-1-simon.marchi@polymtl.ca> References: <20250310151211.2708331-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 10 Mar 2025 15:20:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org From: Simon Marchi The data associated to an internalvar is destroyed when changing the kind of the internalvar, but not when it is destroyed. Fix that by calling clear_internalvar in ~internalvar. A move constructor becomes needed to avoid freeing things multiple times when internalvars are moved (and if we forget it, clang helpfully gives us a -Wdeprecated-copy-with-user-provided-dtor warning). Change-Id: I427718569208fd955ea25e94d341dde356725033 --- gdb/value.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gdb/value.c b/gdb/value.c index 18c9f7494674..8b8b5c8f4de1 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1872,6 +1872,19 @@ struct internalvar : name (std::move (name)) {} + internalvar (internalvar &&other) + : name (std::move(other.name)), + kind (other.kind), + u (other.u) + { + other.kind = INTERNALVAR_VOID; + } + + ~internalvar () + { + clear_internalvar (this); + } + std::string name; /* We support various different kinds of content of an internal variable.