From patchwork Mon Jan 20 12:26:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 105127 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2B5E83858283 for ; Mon, 20 Jan 2025 12:28:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2B5E83858283 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V4HKa9r1 X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C10803858283 for ; Mon, 20 Jan 2025 12:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C10803858283 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C10803858283 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737376020; cv=none; b=FuClNS+f8tWRlYs3w84+z16k1zoVgOJhTltqmGOwcRDj96sLAignkUjJZfMK9TaL0N8EdNQGZao0KXDoHD0GlNre2XU00a/puwf/cBu1EiVapU8O2zka3nSsnsWbhBfi3MmNOZ7FE/xDKbAWHW/t2Eg7TenY0NeKlBFZ/3ycKsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737376020; c=relaxed/simple; bh=tZwMFspwmacqL9LRzKbnuH69xRKOO6SaRxcsvdPyvLM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KtMEQDMwKDJHOqjZoNG8AMrjMWEP0wwC3UfHSMpeDJrfQSrSpfYsNuzPz1AS4x1vCgt1LRxfJmJNW7KjgKrO9qrx65DT3FTgrbpMXGX7AwERfca6vEVDP+3Feh9YbbFlHxSFvgqe0Cz0xgdrDtCEsRkm4zGv8qTJRhYYoYqePl8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C10803858283 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737376020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IvO90swYLcW7yyjEU5w9xoRnhHtBmAkPeRqzEduqiuQ=; b=V4HKa9r1oUE3gcCVvE71oRyWYlAe+yVtK3x4Kt9VIHfBE9GAo4V75KlOrP/AEksYDFa9NW /7Z4XluZfVHa/yqqckJf6j8fT0vb3ERd786BIB0WAJeSiZJ9oZjolFX9U8yN+JZozdCNvV GqpPV41MXbaQvoIdwUsWi4MO76wM0Ow= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-IOPiMOvaOfitwc2itvWNVw-1; Mon, 20 Jan 2025 07:26:59 -0500 X-MC-Unique: IOPiMOvaOfitwc2itvWNVw-1 X-Mimecast-MFC-AGG-ID: IOPiMOvaOfitwc2itvWNVw Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41D0819560B3; Mon, 20 Jan 2025 12:26:58 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.84]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D98419560A7; Mon, 20 Jan 2025 12:26:56 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Tom de Vries Subject: [PATCH] gdb/testsuite: Fix file location for gdb.base/backtrace-through-cu-nodebug Date: Mon, 20 Jan 2025 09:26:09 -0300 Message-ID: <20250120122608.115710-2-guinevere@redhat.com> In-Reply-To: <7fa350c1-a2b7-4284-a59b-be68c1af9221@suse.de> References: <7fa350c1-a2b7-4284-a59b-be68c1af9221@suse.de> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qQXB0328cJsNxTImbmxkY8VhfC1KdwaB0Bp5eNZQUck_1737376018 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org The newly added test gdb.base/backtrace-through-cu-nodebug.exp had a problem in the call to gdb_comiple, that caused the .o files to be outputted in the GDB file tree. This commit fixes the issues in the calls. Reported-By: Tom de Vries --- Hi Tom, Sorry about that, this patch should fix it. I'm not sure if this counts as obvious, so I haven't pushed it yet, do let me know if this is ok :) --- .../gdb.base/backtrace-through-cu-nodebug.exp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp index d6e686539c9..53bf642a92c 100644 --- a/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp +++ b/gdb/testsuite/gdb.base/backtrace-through-cu-nodebug.exp @@ -17,8 +17,8 @@ # trace goes through a function with no debug information. standard_testfile -caller.c -main.c -set objmainfile ${testfile}-main.o -set objcallerfile ${testfile}-caller.o +set objmainfile [standard_output_file ${testfile}-main.o] +set objcallerfile [standard_output_file ${testfile}-caller.o] # Recompile the inferior with or without CFI information, then run the # inferior until the point where the important test starts. @@ -28,7 +28,7 @@ proc prepare_test {has_cfi} { if {$has_cfi} { set extension "cfi" if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ - "${srcdir}/${subdir}/${objcallerfile}" \ + "${objcallerfile}" \ object [list {additional_flags=-fomit-frame-pointer \ -funwind-tables -fasynchronous-unwind-tables}]] != "" } { untested "couldn't compile with cfi" @@ -37,7 +37,7 @@ proc prepare_test {has_cfi} { } else { set extension "no-cfi" if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ - "${srcdir}/${subdir}/${objcallerfile}" \ + "${objcallerfile}" \ object [list {additional_flags=-fomit-frame-pointer \ -fno-unwind-tables \ -fno-asynchronous-unwind-tables}]] != "" } { @@ -45,8 +45,8 @@ proc prepare_test {has_cfi} { return false } } - if {[gdb_compile [list "${srcdir}/${subdir}/${objmainfile}" \ - "${srcdir}/${subdir}/${objcallerfile}"] \ + if {[gdb_compile [list "${objmainfile}" \ + "${objcallerfile}"] \ "${binfile}-${extension}" binfile {}] != ""} { untested "couldn't link object files" return false @@ -66,7 +66,7 @@ proc prepare_test {has_cfi} { } if {[gdb_compile "${srcdir}/${subdir}/${srcfile2}" \ - "${srcdir}/${subdir}/${objmainfile}" \ + "${objmainfile}" \ object {debug}] != "" } { untested "couldn't compile main file" return