From patchwork Thu Jan 16 15:52:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 104917 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 41BA1384F02E for ; Thu, 16 Jan 2025 15:54:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41BA1384F02E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=E+Jh11Hk X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id F3609384F027 for ; Thu, 16 Jan 2025 15:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3609384F027 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F3609384F027 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737042738; cv=none; b=Am6uZrb6LfZAiLDndYFrj39lHYvc60T8IhIW796u2UTYowfMuGB+4T6FP/InVBe3Mt9ZJH6DEB3ryeSDmjgwdmIcgPFlnLRKQf/8wWFR8fuN+/i1lwydF90v3DDzaJC3dIfSFYvlD0p14U/MhifoQynu3+JqPb5h9Tp4a/L0aOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737042738; c=relaxed/simple; bh=3H17gJsds4nFRVqdORT3OmF8SaD4jsiX7Op0DwXQT4g=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=Br+s/0WYCXf+g01WezJvL7sBhEJv9jiYqarPIp5GVNJcW03fgNT1Lvp01B/ONCuW3ux0Dy0/J8ZKdViivCPAG4IKQtASJ4G5HoXW/adjjq/yYeQl+BuKiSVBu6AAownRGiT9SZDHBaUdJ4f+49HFKIUPLXw0ei5Yew1UdlpUb40= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3609384F027 Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-3ce34c6872aso8842075ab.0 for ; Thu, 16 Jan 2025 07:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1737042737; x=1737647537; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VBo2m3HzBoHZE8dWg2ExJpwsUSMBPOQNSR2pLel5hAI=; b=E+Jh11HkddY/TKnRBeGoBGO9UhXdRzy+vv5E/3CYESc57gTGAJ2/0iDA5sRaJ2Zd2Q 76+XTL2e/PoZgX+BhLM5RkjoyUxLSuhD872+McRIdH1u9WrFiEF6LS2xlR4R2+40U2Zk 0ddm5Qtuzh8XXF8f71KTDxZ6R4vKSrbpX/gv5FLeeBDprK9/WkY4pkum40obwkRCr4Wb ghWlaA05xBv+w5yvJMZTiX1abVt9gRudmvcozul7wKVrRUzQkDi23LGHbRh4/QVg5E+o yZ1OlBGeqSPnlGkldXfQaTC40TSF9XsmBcR6o1c+0ahZ3sUQ9ln0uD5e0Q9YI4X+FFZJ 1I7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042737; x=1737647537; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VBo2m3HzBoHZE8dWg2ExJpwsUSMBPOQNSR2pLel5hAI=; b=taL04KibLQFvGNJlFKmeKPEwRZPK7yEGrxNjvyPFKj/ZV70JMrZ7mfHQZX2hpH8e67 XUkv4IY/b6dl/QpnJV+2b+tU/1dlJX9L/j+OS/KG8pIB8Lk5LgE60sHX2bklU7oTkbKn /fQYzn/x24vbgfIywsALUVZpHhHFv5nA4IamQZcuRSIZkrFFSY30pkV0H4x3PhT3c4I6 tvPnysgq8ayFCsFK3TiX4n8X+7c7Gir7WtRw6yWvb8tmrzNVx07WveUqPuiPJLBJ8RpE ezLeelCKX9LlulS0oN1KXi3zggQ8+eDUP58/b6paH2T+7NwkfRac0vGnZqomjNY6q5Ov +OIg== X-Gm-Message-State: AOJu0YyDWxJEHyDKqLXzex0XU+BNOexRdtL8Kv1M6LOvUFYo1x1AIQoR Q51qneWI1SrLwQdKPwSWxH0RFNJre1bqohISEMMA0r6W5pw1ArvMfSMVrHwnJqdv85hLOI9h6AQ = X-Gm-Gg: ASbGncvfWHPW1HIjHKjP8geeFyb0SGbfM5Nz+Jg2lk3zYwxn4nQuLChetHcialfCq5Y P9RuCyy0jRm2TmMwnizVuolQOgJLJx86hCLKPSKKRyl35B2RjzfcaKDmvTlAhOdqiO05rdnbr7a HSAIAixRtkujBtxCtQsDq3N/X6jeqe1iV0cmRtxl9CrMBTxHrrWvg3zszTLnolE6A0XtOxBYGsJ YFFftdJtNJNcXYKFQYLzO4ZTOQ+yRqZnuFn8wH5r1yevm1iBGznr561cLNFSjvn0dlyTUkZ2+Kp 687SvfQaHK/aQo6eekHJ X-Google-Smtp-Source: AGHT+IGt6vRgHdCXE/El4hafgkfcopuuZAxUA2KRZmD7L4evF1eT4ryoVXThEIdiw+C1pPiGbwWnbg== X-Received: by 2002:a92:b710:0:b0:3ce:403a:8be6 with SMTP id e9e14a558f8ab-3ce403a8e41mr229184225ab.20.1737042737226; Thu, 16 Jan 2025 07:52:17 -0800 (PST) Received: from localhost.localdomain (97-118-36-154.hlrn.qwest.net. [97.118.36.154]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3cf71a9e5bcsm606495ab.28.2025.01.16.07.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:52:16 -0800 (PST) From: Tom Tromey Date: Thu, 16 Jan 2025 08:52:13 -0700 Subject: [PATCH 2/3] Remove gdb_index_unpack MIME-Version: 1.0 Message-Id: <20250116-remove-a-class-v1-2-f0cfe6eb5c3a@adacore.com> References: <20250116-remove-a-class-v1-0-f0cfe6eb5c3a@adacore.com> In-Reply-To: <20250116-remove-a-class-v1-0-f0cfe6eb5c3a@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org gdb_index_unpack is not used and can be removed. The include of extract-store-integer.h is also no longer needed by this file. --- gdb/dwarf2/index-common.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gdb/dwarf2/index-common.h b/gdb/dwarf2/index-common.h index b9e0a632508dea68403c0d686ea9d6c6d8b02bbc..ca377213edc78b00442b973cd5c4df3e3f5f1790 100644 --- a/gdb/dwarf2/index-common.h +++ b/gdb/dwarf2/index-common.h @@ -20,7 +20,6 @@ #ifndef GDB_DWARF2_INDEX_COMMON_H #define GDB_DWARF2_INDEX_COMMON_H -#include "extract-store-integer.h" #include "hashtab.h" /* The suffix for an index file. */ @@ -32,15 +31,6 @@ architecture-independent. */ typedef uint32_t offset_type; -/* Unpack a 32-bit little-endian value. */ - -static inline offset_type -gdb_index_unpack (const gdb_byte *value) -{ - return (offset_type) extract_unsigned_integer (value, sizeof (offset_type), - BFD_ENDIAN_LITTLE); -} - /* The hash function for strings in the mapped index. This is the same as SYMBOL_HASH_NEXT, but we keep a separate copy to maintain control over the implementation. This is necessary because the hash function is tied to the