From patchwork Thu Jan 16 15:52:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 104919 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C896384F026 for ; Thu, 16 Jan 2025 15:56:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C896384F026 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Db7X9O8U X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 7686E384F01C for ; Thu, 16 Jan 2025 15:52:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7686E384F01C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7686E384F01C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737042736; cv=none; b=byNfWcYKoS9NlvFZlTFB1Dv+/cov97llrf3H+2RoQ2PA6w1xT611DD8mTeNDey+kERKNskO2wvwH5tV3GEETIIITmuYRis8vRy1nrlZhyOgLfhqV42iz+YuMp8hYO81A6BNtHkw1j5XCHN7FbhLDzhlgfWWcUjHvZFG3k7st+XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737042736; c=relaxed/simple; bh=dQMPgkdCGB1eoApwFdnDypHhRZp6f+mEmRwkEP4w/jg=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=pqG7HPLhhTNgRoeX7ewheLy0w2v6ESK/2i+IRawcBuJbHY7zihpMB4Yrv5kPzDqb4XYZWJIVuELsXHtLNz4ZzS6uBs1KYLDRQXKalKDv+VFoYWv/kYtgbI9NumPsrdbl+ytEG/0gI8FeRh6w5HBlmh+PGaDfdRGTFspXTbvMSvg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7686E384F01C Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-844df397754so35004339f.2 for ; Thu, 16 Jan 2025 07:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1737042736; x=1737647536; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tP/lv6x9bcKCCrGqxmYads8U9IWwbTh4DzpM+R6ntKU=; b=Db7X9O8UfhbCiN/coJuUYDDawcV3IkyAE3y9hVdLtC8oEAyWxwPJscQ/vHM0i7249g t0mQG6xgKUTcL/UvxS9OwyT2ia6pGd7k3liBCmOh9Uf/3KRD6uM01kjL335Al0nRyhuB uUKKiShBDLhjyWsnI4DdQF2SnSk4h0u6QWxunuhMmwcDy+poRPHVBhuUXGYabFPVs1Ul 2eaOINcvLTj1v/KxArbhmjry1DiIC6Jkp4C01BPzx0XlOFsDYFl9vKA8N4d+saFJMHSh nhsZ9/YGUualsDBjSi4V3r9556r+7kZpZOfdEoIdfMDX5e4Krhx7AJ3a8YRZPtywyWih 7vKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737042736; x=1737647536; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tP/lv6x9bcKCCrGqxmYads8U9IWwbTh4DzpM+R6ntKU=; b=G4mDvqWsJ62TDInJs3pA+ws8cFXyMywoku7n6dKQ8tqJ+7pcKtYwOIPTdqZin/jimc fOTZrM36FjLn2tvJSefRVJQqdQn1rOp8iWArVvn9QCOYbtxNeeDIA/SN+J175j0MuWRB 6CeKeiOcPs0tK8a8d0nhwmpLwjX2z2qDzF5GoUNYcsZjfHBuDpysYjrv+/vfut9/hBPO zkNmAO4zER+Iy9PVZeEB2vF62G88LJCb/VCK8WN1ueA571ydp+a7uQp1tu0ZV7j4CXSU HqE2xSue8kQjck5HC6c+JAPPKJ2vAkvcdiFaG5ZY1o7+uTEcwXYYDRo1L2OSM0kJC5z8 K49Q== X-Gm-Message-State: AOJu0YyqhW5otlg/FHRzHZnGla3ic6WPlXYdcHrfCmfgnEfXeVXDFTYD 7TIWXLPsYABlOswSfafKklDKjlvS2vsBWDPZ7fy9TCbNGp1uPn77zy47v3J0lRYxL10n/xSINIA = X-Gm-Gg: ASbGncsWYNnU0ufhHzqpyz0Fmcuo0EfzbV5GOjZrOKuqinSffGhF0z6VCSmMHXG0gI+ jzHJZHtOuXkCR6/gL7Eq5hKPQa2JlIl2Mfd+GhNRD2c7RKWobTzzJ6TPlrYdkZop8tViSzTi34Y xtKTBU8eu++bvF82DsBibpAoGh3dE6jgD4eZaS3yzJvguh5JLsX9vJdaOZda5uQk6jbTbNoPAQH MVQwev3Vu3pFKnNNXucweCBP7ah+u1g7z8MYMvSPltijVUCg1r9yjjoDEdYpDAYoyRtsbV5Gh1g a0pfMvg4bOmvBKfPWcMO X-Google-Smtp-Source: AGHT+IEjeAMWbxpVtIz8Ic31kuTjACDxKRTRyJZqBqxyfCNQYZhwHCkUUmt8XOuH+veih3hBRStZlg== X-Received: by 2002:a92:c248:0:b0:3a7:e732:4713 with SMTP id e9e14a558f8ab-3ce3a9c1aa9mr273861835ab.15.1737042735726; Thu, 16 Jan 2025 07:52:15 -0800 (PST) Received: from localhost.localdomain (97-118-36-154.hlrn.qwest.net. [97.118.36.154]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3cf71a9e5bcsm606495ab.28.2025.01.16.07.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2025 07:52:15 -0800 (PST) From: Tom Tromey Date: Thu, 16 Jan 2025 08:52:12 -0700 Subject: [PATCH 1/3] Add missing includes of extract-store-integer.h MIME-Version: 1.0 Message-Id: <20250116-remove-a-class-v1-1-f0cfe6eb5c3a@adacore.com> References: <20250116-remove-a-class-v1-0-f0cfe6eb5c3a@adacore.com> In-Reply-To: <20250116-remove-a-class-v1-0-f0cfe6eb5c3a@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.2 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org I found a number of .c files that need to include extract-store-integer.h but that were only including it indirectly. This patch adds the missing includes. This change enables the next patch. --- gdb/compile/compile-loc2c.c | 1 + gdb/dwarf2/aranges.c | 1 + gdb/dwarf2/expr.c | 1 + gdb/dwarf2/frame.c | 1 + gdb/dwarf2/index-write.c | 1 + gdb/dwarf2/loc.c | 1 + gdb/dwarf2/read-debug-names.c | 1 + gdb/dwarf2/read-gdb-index.c | 1 + gdb/dwarf2/read.c | 1 + gdb/gdbtypes.c | 1 + 10 files changed, 10 insertions(+) diff --git a/gdb/compile/compile-loc2c.c b/gdb/compile/compile-loc2c.c index 42370447052f10545b94d2df877e0c90a7be110b..df05c0140f0508d1ff3772916e541923a8f8842f 100644 --- a/gdb/compile/compile-loc2c.c +++ b/gdb/compile/compile-loc2c.c @@ -31,6 +31,7 @@ #include "dwarf2/frame.h" #include "value.h" #include "gdbarch.h" +#include "extract-store-integer.h" diff --git a/gdb/dwarf2/aranges.c b/gdb/dwarf2/aranges.c index e391ca6f933479dc9bfeac65061ed1b77f1f8ed7..af14f82126b1b5e596f67a62afa887afbe1fd1d8 100644 --- a/gdb/dwarf2/aranges.c +++ b/gdb/dwarf2/aranges.c @@ -19,6 +19,7 @@ #include "dwarf2/aranges.h" #include "dwarf2/read.h" +#include "extract-store-integer.h" /* See aranges.h. */ diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index ee1522b7437818e0bca14ca0e91f727e50fb39f7..0977cfcab546fb97ba7231f2aac3c059a1debbc2 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -33,6 +33,7 @@ #include "gdbsupport/underlying.h" #include "gdbarch.h" #include "objfiles.h" +#include "extract-store-integer.h" /* This holds gdbarch-specific types used by the DWARF expression evaluator. See comments in execute_stack_op. */ diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c index 6d8a4fb5a9ea561ae98ec36669bfeae253b82ffa..2f9b8eab69448bb3315ffbeb73c521152096e3d5 100644 --- a/gdb/dwarf2/frame.c +++ b/gdb/dwarf2/frame.c @@ -31,6 +31,7 @@ #include "regcache.h" #include "value.h" #include "record.h" +#include "extract-store-integer.h" #include "complaints.h" #include "dwarf2/frame.h" diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index 1008d19e1692c8774ebb9c4ef987a49fd1fda179..70688d7fddf59fa8cfc66e370c50ec2a63046c4d 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -40,6 +40,7 @@ #include "dwarf2/tag.h" #include "gdbsupport/gdb_tilde_expand.h" #include "dwarf2/read-debug-names.h" +#include "extract-store-integer.h" #include #include diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c index 989d33901e01070d05c1009cdd80db60af4f0b2f..a01161e83f7d75816aa791f51bd38d8830706b0a 100644 --- a/gdb/dwarf2/loc.c +++ b/gdb/dwarf2/loc.c @@ -46,6 +46,7 @@ #include #include "gdbsupport/underlying.h" #include "gdbsupport/byte-vector.h" +#include "extract-store-integer.h" static struct value *dwarf2_evaluate_loc_desc_full (struct type *type, const frame_info_ptr &frame, const gdb_byte *data, diff --git a/gdb/dwarf2/read-debug-names.c b/gdb/dwarf2/read-debug-names.c index e6f1fce4eb4bc7057223941cb78b3a8f84232b45..ffc4f3ad5eb028662c694e124c85de105067ff55 100644 --- a/gdb/dwarf2/read-debug-names.c +++ b/gdb/dwarf2/read-debug-names.c @@ -27,6 +27,7 @@ #include "mapped-index.h" #include "read.h" #include "stringify.h" +#include "extract-store-integer.h" /* This is just like cooked_index_functions, but overrides a single method so the test suite can distinguish the .debug_names case from diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c index 4dea55957346432bba4b3e262e10aa2ffa9d77d7..83bd2e08c5df403d28d662695f409e6428bb270c 100644 --- a/gdb/dwarf2/read-gdb-index.c +++ b/gdb/dwarf2/read-gdb-index.c @@ -28,6 +28,7 @@ #include "gdbsupport/gdb-checked-static-cast.h" #include "mapped-index.h" #include "read.h" +#include "extract-store-integer.h" /* When true, do not reject deprecated .gdb_index sections. */ static bool use_deprecated_index_sections = false; diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index e52e26f340ca3b485577f27da14c567808b4af5f..9484754447746b8a14b1bde2092407edb2aba298 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -97,6 +97,7 @@ #include "dwarf2/error.h" #include #include "gdbsupport/unordered_set.h" +#include "extract-store-integer.h" /* When == 1, print basic high level tracing messages. When > 1, be more verbose. diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 0928e24446708fd654194298b0dafa80730e213c..3f78230289f0ee58d598f8e89d26f5f251eb94c4 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -44,6 +44,7 @@ #include "gmp-utils.h" #include "rust-lang.h" #include "ada-lang.h" +#include "extract-store-integer.h" /* The value of an invalid conversion badness. */ #define INVALID_CONVERSION 100