From patchwork Wed Jan 15 16:30:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aktemur, Tankut Baris" X-Patchwork-Id: 104844 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 444903851A99 for ; Wed, 15 Jan 2025 16:33:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 444903851A99 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ZCbfSuce X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by sourceware.org (Postfix) with ESMTPS id 740F93851A83 for ; Wed, 15 Jan 2025 16:31:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 740F93851A83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 740F93851A83 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736958685; cv=none; b=wSdVRAEZdPzzJtIaRkp5Qr9wvSDKz6d5bT3D1/x8KQoYde+SOnIMUcFli7s4wMoIcm2E9Z1RpfaL8dz0wTutSoEiblbUwbViZmWILzbovuvAkl1K74AS1/OagSd7Opng1Oqw5PhuKjVb6N12dOSvK1Ai23P8T5qzkqPDEQUmdLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736958685; c=relaxed/simple; bh=Sd19qWNsKyHf2WvnXkV6mcOJ6NQf5KZOw7RRGpso6xE=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=V7BqLAWjoqBslIFb5+EtPGdP21ZI/PgpMx8YG6Up2Kvyo01eYtPIoEqydfkBi64HF1WLD6qD0M8G0QJIKW7hrgQPED5Nc08QVLEiY0oZkqX+dtgF1rv96S5AfVLQdPbPJKuMO4+zzJs9vWVtt2tiGGi0miF6DlY57+nmrtR2MpE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 740F93851A83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736958686; x=1768494686; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=Sd19qWNsKyHf2WvnXkV6mcOJ6NQf5KZOw7RRGpso6xE=; b=ZCbfSuce6nVXj8qqC/4UEbOU+qUylGD/iM0w3qxTO173AO8NG6qkz0Ag tVDNjnEkyhoNr6L3f10Vc54YJYCqwICrWs8ZS8tHg6fkv448VGtSz9TSA Lkz2TAaD+OMkeN8aBszO7y2gD3ZbpDXKC7sYNtQRLGVb8QxWTNHVjOlOc jPxQRHLSHhAiYExNEPso6NX9G6qa33wjSvKIU4o9IqgLRSxv1zPQpuIS+ DxVMgh2KuaLCUtMFbHvFV5wR8gAQCRjB5vjJzlsspBVCmHt3P1IN25duy +6EFdD/mIsbRp2mdILjO1RBBj8FKW6ha2XnHrzLqgQOWiwW41VmE5L/It A==; X-CSE-ConnectionGUID: 5OZuCFeDSIaDEM4NFgp8jw== X-CSE-MsgGUID: RajTdJChS9KnMgtc5LW3Jw== X-IronPort-AV: E=McAfee;i="6700,10204,11316"; a="47790347" X-IronPort-AV: E=Sophos;i="6.13,206,1732608000"; d="scan'208";a="47790347" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2025 08:31:04 -0800 X-CSE-ConnectionGUID: nzgVXgjLT3OGjNfOb6PIhg== X-CSE-MsgGUID: PqXxqpWaRC2Xdo5ebm7yjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="110313395" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2025 08:31:01 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [Pushed as obvious 3/3] gdb: boolify the 'in_g_packet' field of remote's 'packet_reg' Date: Wed, 15 Jan 2025 17:30:20 +0100 Message-Id: <20250115163020.3292754-3-tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250115163020.3292754-1-tankut.baris.aktemur@intel.com> References: <20250115163020.3292754-1-tankut.baris.aktemur@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~patchwork=sourceware.org@sourceware.org Boolify the 'in_g_packet' of the 'packet_reg' struct that is used in remote.c. --- gdb/remote.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index 79d91d6251a..64622dbfcdf 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -466,7 +466,7 @@ struct packet_reg long offset; /* Offset into G packet. */ long regnum; /* GDB's internal register number. */ LONGEST pnum; /* Remote protocol register number. */ - int in_g_packet; /* Always part of G packet. */ + bool in_g_packet; /* Always part of G packet. */ /* long size in bytes; == register_size (arch, regnum); at present. */ /* char *name; == gdbarch_register_name (arch, regnum); @@ -1924,7 +1924,7 @@ map_regcache_remote_table (struct gdbarch *gdbarch, struct packet_reg *regs) for (regnum = 0, offset = 0; regnum < num_remote_regs; regnum++) { - remote_regs[regnum]->in_g_packet = 1; + remote_regs[regnum]->in_g_packet = true; remote_regs[regnum]->offset = offset; offset += register_size (gdbarch, remote_regs[regnum]->regnum); } @@ -8997,11 +8997,11 @@ remote_target::process_g_packet (struct regcache *regcache) continue; if (offset >= sizeof_g_packet) - rsa->regs[i].in_g_packet = 0; + rsa->regs[i].in_g_packet = false; else if (offset + reg_size > sizeof_g_packet) error (_("Truncated register %d in remote 'g' packet"), i); else - rsa->regs[i].in_g_packet = 1; + rsa->regs[i].in_g_packet = true; } /* Looks valid enough, we can assume this is the correct length